From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A188CCF9E3 for ; Mon, 10 Nov 2025 13:30:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIRyB-0004t5-Jj; Mon, 10 Nov 2025 08:30:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIReK-0008WS-77 for qemu-devel@nongnu.org; Mon, 10 Nov 2025 08:09:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIReH-0007Op-1X for qemu-devel@nongnu.org; Mon, 10 Nov 2025 08:09:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762780170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=unkVU3Mob56G/23Yd9KyW8Y8lyUM3v3cRPBSbnhPFAI=; b=KhVysUey3IxdPquBXKiiZBYaGATU50hzBCgaJhtP0Wcw1mf3lq+iau3bs4HEVjK2MBzXRO t9Sa9pYu5voMk/NzeufKDIvuug2ClQe65woZqt4+YUV22Igeger65FWtHG5SInCnjyiFfN EgQSqgtP/MWmUF7XxdqLIVH9HiE2NgU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-5huX6p1FOv2xcMz1XWGJvA-1; Mon, 10 Nov 2025 08:09:27 -0500 X-MC-Unique: 5huX6p1FOv2xcMz1XWGJvA-1 X-Mimecast-MFC-AGG-ID: 5huX6p1FOv2xcMz1XWGJvA_1762780166 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3681F18002C4; Mon, 10 Nov 2025 13:09:26 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9AF481800576; Mon, 10 Nov 2025 13:09:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DE9EE21E6A27; Mon, 10 Nov 2025 14:09:22 +0100 (CET) From: Markus Armbruster To: =?utf-8?Q?Cl=C3=A9ment?= Chigot Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com, eblake@redhat.com Subject: Re: [PATCH v2 5/5] vvfat: add support for "fat-size" options In-Reply-To: (=?utf-8?Q?=22Cl=C3=A9ment?= Chigot"'s message of "Mon, 10 Nov 2025 13:46:05 +0100") References: <20251107145327.539481-1-chigot@adacore.com> <20251107145327.539481-6-chigot@adacore.com> <87zf8umbzh.fsf@pond.sub.org> Date: Mon, 10 Nov 2025 14:09:22 +0100 Message-ID: <87bjlakpa5.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Cl=C3=A9ment Chigot writes: > On Mon, Nov 10, 2025 at 11:13=E2=80=AFAM Markus Armbruster wrote: >> >> Cl=C3=A9ment Chigot writes: >> >> > This allows more flexibility to vvfat backend. The values of "Number of >> > Heads" and "Sectors per track" are based on SD specifications Part 2. >> > >> > Due to the FAT architecture, not all sizes are reachable. Therefore, it >> > could be round up to the closest available size. >> > >> > FAT32 has not been adjusted and thus still default to 504 Mib. >> > >> > For floppy, only 1440 Kib and 2880 Kib are supported. >> > >> > Signed-off-by: Cl=C3=A9ment Chigot >> >> [...] >> >> > diff --git a/qapi/block-core.json b/qapi/block-core.json >> > index 8a479ba090..0bcb360320 100644 >> > --- a/qapi/block-core.json >> > +++ b/qapi/block-core.json >> > @@ -3478,11 +3478,17 @@ >> > # (default: true) >> > # (since 10.2) >> > # >> > +# @fat-size: size of the device in bytes. Due to FAT underlying >> > +# architecture, this size can be rounded up to the closest valid >> > +# size. >> > +# (since 10.2) >> > +# >> >> Can you explain again why you moved from @size to @fat-size? > > Just to be sure, you mean in the above comment, in the commit message or = both ? Just to me, because I'm not sure I like the change, but that may well be due to a lack of understanding of your reasons. [...]