All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toon Claes <toon@iotcl.com>
To: Junio C Hamano <gitster@pobox.com>, Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] bundle-uri: ignore bundles without uri
Date: Tue, 16 Sep 2025 17:25:58 +0200	[thread overview]
Message-ID: <87bjnao1vd.fsf@iotcl.com> (raw)
In-Reply-To: <xmqqbjnfmvwo.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> I tend to agree.  Instead of papering over a misconfiguration, it
> would be better to let the users know, so they have a chance to
> report and/or correct such a misconfiguration.

So are you okay if I do `return error("some message")` instead of
`return -1`, or do you expect more of a change?

-- 
Cheers,
Toon

  reply	other threads:[~2025-09-16 15:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 16:46 [PATCH 0/2] Make git-clone(1) more resilient when using bundle-URI Toon Claes
2025-09-12 16:46 ` [PATCH 1/2] bundle-uri: ignore bundles without uri Toon Claes
2025-09-12 17:11   ` Justin Tobler
2025-09-12 17:18     ` Junio C Hamano
2025-09-16 15:25       ` Toon Claes [this message]
2025-09-16 16:59         ` Junio C Hamano
2025-09-12 16:46 ` [PATCH 2/2] bundle-uri: do not abort on invalid packet line Toon Claes
2025-09-12 17:37   ` Justin Tobler
2025-09-17  8:40     ` Toon Claes
2025-09-17 14:30       ` Justin Tobler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjnao1vd.fsf@iotcl.com \
    --to=toon@iotcl.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jltobler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.