Re: [PATCH] dt-bindings: thermal: Convert marvell,armada370-thermal to DT schema

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Rob,

On 02/07/2025 at 17:55:27 -05, "Rob Herring (Arm)" <robh@kernel.org> wrote:

> Convert the Marvell Armada 3xx/XP thermal binding to schema.
>
> Drop the AP80x and CP110 as they have long been deprecated and have
> been replaced by a new binding.

Totally fine with that, but then I would go even further and also drop
the legacy binding implying a size of 4 on the second reg range?

> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---

...

> +examples:
> +  - |
> +    thermal@d0018300 {
> +        compatible = "marvell,armada370-thermal";
> +        reg = <0xd0018300 0x4
> +               0xd0018304 0x4>;
> +    };

This example is showing a legacy binding. Even if we decide to keep
supporting it, I think you would prefer to replace the second line:

           reg = <0xd0018300 0x4
  -               0xd0018304 0x4>;
  +               0xd0018304 0x8>;

Thanks,
Miquèl