From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE0E2367BC; Thu, 12 Jun 2025 10:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749724230; cv=none; b=h+0E7iHo3RBotLiIBIlGtnuf2SiZVHMyXlHzquRqYt1qUG4Sw9I32EgD7oFav0OxJyw1ftOndUlwJ7xgl8JFbXmGk2sUWrPmdZhvirkZd6JGaDx2B1EETjy5QAsSfCCpFEts6VcohcGA9YyWkfHLbTiPqUfRFo7NNj68pPg76PA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749724230; c=relaxed/simple; bh=3DEc4h66KpM39d9s61Ex2AB7LLJV25GL4TXRcKI5g9k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=iZo12j7ux+Dv2OIVjGdiGF9VWDvjAJHhSuhg3F8Yhu3TYKMeg7fsa5LywFx8J+Al8MgF4jo6qnHSxWGe7KAz5Yl3OHsmjeVeoRRxqtdYadB3RjXSd04SrZKb74P4z/W4iSAZZKQqIbVVCHU0xRqKM7UYaDYp5fD3kWYekzW2bZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gu8Ia/uB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gu8Ia/uB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C5BCC4CEEA; Thu, 12 Jun 2025 10:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749724230; bh=3DEc4h66KpM39d9s61Ex2AB7LLJV25GL4TXRcKI5g9k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gu8Ia/uB/zXp9zILhzjNZwhHRUGppAZLKYL0Y9M36mf7Op4uV/G0ILdntfsh1FhQ6 yqDj+1mCgeXlcDp8KT3el9cfRrjhWMHc0VRbjmbupczLOCDyoU466UAN+9ogDneodJ Vk6avv6cDdSUkkY74RIVntyr5y02OkqJ5sDsT7MeYgwFolE/U6ZEktL4pa9+1iRI/D wYyi3wqpN/NSRdUOg2tWigjHNmEZ9PD827+GIZOkK5kMftmlUA7u7MPuSjBDI5+aM6 /EyqnF74hRUCjTnoH78r6Ko8gt0MgqviR6KjT0dVJSwxTWp9me2+t0AUuEuG5tX3w8 FXRLp3RmoclEQ== Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D0DAA1AF6CD7; Thu, 12 Jun 2025 12:30:06 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Steven Rostedt , LKML , Linux trace kernel , bpf@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend Subject: Re: [PATCH] xdp: Remove unused events xdp_redirect_map and xdp_redirect_map_err In-Reply-To: <20250611155615.0c2cf61c@batman.local.home> References: <20250611155615.0c2cf61c@batman.local.home> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 12 Jun 2025 12:30:06 +0200 Message-ID: <87bjqtb6c1.fsf@toke.dk> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Steven Rostedt writes: > From: Steven Rostedt > > Each TRACE_EVENT() defined can take up around 5K of text and meta data > regardless if they are used or not. New code is being developed that will > warn when a tracepoint is defined but not used. > > The trace events xdp_redirect_map and xdp_redirect_map_err are defined but > not used, but there's also a comment that states these are kept around for > backward compatibility. Which is interesting because since they are not > used, any old BPF program that expects them to exist will get incorrect > data (no data) when they use them. It's worse than not working, it's > silently failing. > > Remove them as they will soon cause warnings, or if they really need to > stick around, then code needs to be added to use them. > > Signed-off-by: Steven Rostedt (Google) I guess that makes sense; I have no objections to getting rid of them. Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen