From: Junichi Uekawa <dancer@netfort.gr.jp>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: dancer@debian.org, mst@redhat.com, qemu-devel@nongnu.org,
adelva@google.com, uekawa@chromium.org,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
kvm@vger.kernel.org
Subject: Re: [PATCH] Fix comment for virtio-9p
Date: Tue, 27 May 2025 15:23:36 +0900 [thread overview]
Message-ID: <87bjrea7x3.dancerj-dancer@netfort.gr.jp> (raw)
In-Reply-To: <2636618a-5000-449a-bc2d-f7bf253bf26d@tls.msk.ru>
On Tue, 27 May 2025 15:11:36 +0900,
Michael Tokarev wrote:
>
> 27.05.2025 07:11, dancer@debian.org wrote:
> > From: Junichi Uekawa <uekawa@chromium.org>
> >
> > virtio-9p is not a console protocol, it's a file sharing protocol. Seems
> > like an artifact of old copy-and-paste error.
>
> > -#define VIRTIO_ID_9P 9 /* 9p virtio console */
> > +#define VIRTIO_ID_9P 9 /* virtio 9p */
>
> While the old one was obviously wrong, I don't think the new
> wording makes much sense, since it merely repeats the name of
> the constant :)
>
> How about "virtio 9p file sharing protocol" instead ? :)
Sounds better!
I also found another case, added to the follow-up.
next prev parent reply other threads:[~2025-05-27 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 4:11 [PATCH] Fix comment for virtio-9p dancer
2025-05-27 6:11 ` Michael Tokarev
2025-05-27 6:23 ` Junichi Uekawa [this message]
2025-05-27 6:22 ` dancer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjrea7x3.dancerj-dancer@netfort.gr.jp \
--to=dancer@netfort.gr.jp \
--cc=adelva@google.com \
--cc=dancer@debian.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uekawa@chromium.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.