All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Huacai Chen <chenhuacai@gmail.com>
Cc: Huacai Chen <chenhuacai@loongson.cn>,
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
	Xuefeng Li <lixuefeng@loongson.cn>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	stable@vger.kernel.org, Yinbo Zhu <zhuyinbo@loongson.cn>
Subject: Re: [PATCH] irqchip/loongson-liointc: Support to set IRQ_TYPE_EDGE_BOTH
Date: Sun, 06 Apr 2025 12:18:16 +0200	[thread overview]
Message-ID: <87bjt9wq3b.ffs@tglx> (raw)
In-Reply-To: <CAAhV-H5sO0x1EkWks5QZ8ah-stB7JbDk6eFFeeonXD6JT9fHAw@mail.gmail.com>

On Sun, Apr 06 2025 at 17:46, Huacai Chen wrote:
> On Thu, Apr 3, 2025 at 11:48 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>> But it won't trigger on both. So no, you cannot claim that this fixes
>> anything.
> Yes, it won't trigger on both (not perfect), but it allows drivers
> that request "both" work (better than fail to request), and there are

By some definition of 'work'. There is probably a good technical reason
why those drivers expect EDGE_BOTH to work correctly and otherwise fail
to load.

You completely fail to explain, why this hack actually 'works' and what
the implications are for such drivers.

> other irqchip drivers that do similar things.

Justifying bogosity with already existing bogosity is not a technical
argument.

Thanks,

        tglx

  reply	other threads:[~2025-04-06 10:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02  9:25 [PATCH] irqchip/loongson-liointc: Support to set IRQ_TYPE_EDGE_BOTH Huacai Chen
2025-04-03 15:48 ` Thomas Gleixner
2025-04-06  9:46   ` Huacai Chen
2025-04-06 10:18     ` Thomas Gleixner [this message]
2025-04-06 12:46       ` Huacai Chen
2025-04-06 14:19         ` Thomas Gleixner
2025-04-08 12:37           ` Huacai Chen
2025-04-08 16:05             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjt9wq3b.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=chenhuacai@gmail.com \
    --cc=chenhuacai@loongson.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=loongarch@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=zhuyinbo@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.