All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Bibo Mao <maobibo@loongson.cn>
Cc: Song Gao <gaosong@loongson.cn>,
	 Jiaxun Yang <jiaxun.yang@flygoat.com>,
	qemu-devel@nongnu.org,  Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v5 4/6] hw/loongarch/virt: Eliminate error_propagate()
Date: Thu, 20 Mar 2025 07:05:27 +0100	[thread overview]
Message-ID: <87bjtwi6e0.fsf@pond.sub.org> (raw)
In-Reply-To: <20250320032158.1762751-5-maobibo@loongson.cn> (Bibo Mao's message of "Thu, 20 Mar 2025 11:21:56 +0800")

Bibo Mao <maobibo@loongson.cn> writes:

> When there is an error, it is put into a local variable and then
> propagated to somewhere else. Instead the error can be set right
> away, error propagation can be removed.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2025-03-20  6:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20  3:21 [PATCH v5 0/6] target/loongarch: Fix some issues reported from coccinelle Bibo Mao
2025-03-20  3:21 ` [PATCH v5 1/6] target/loongarch: Fix error handling of KVM feature checks Bibo Mao
2025-03-20  3:21 ` [PATCH v5 2/6] hw/loongarch/virt: Fix error handling in cpu plug Bibo Mao
2025-03-20  6:16   ` Markus Armbruster
2025-03-20  6:30     ` bibo mao
2025-03-20  7:25       ` Markus Armbruster
2025-03-20  7:40         ` bibo mao
2025-03-20  3:21 ` [PATCH v5 3/6] hw/loongarch/virt: Fix error handling in cpu unplug Bibo Mao
2025-03-20  3:21 ` [PATCH v5 4/6] hw/loongarch/virt: Eliminate error_propagate() Bibo Mao
2025-03-20  6:05   ` Markus Armbruster [this message]
2025-03-20  3:21 ` [PATCH v5 5/6] target/loongarch: Remove unnecessary temporary variable assignment Bibo Mao
2025-03-20  3:21 ` [PATCH v5 6/6] target/loongarch: Clean up virt_cpu_irq_init() error handling Bibo Mao
2025-03-20  7:01 ` [PATCH v5 0/6] target/loongarch: Fix some issues reported from coccinelle Markus Armbruster
2025-03-20  7:07   ` bibo mao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjtwi6e0.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=gaosong@loongson.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=maobibo@loongson.cn \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.