From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: Re: [PATCH 10/22] system: propagate Error to gdbserver_start (and other device setups)
Date: Thu, 09 Jan 2025 19:45:08 +0000 [thread overview]
Message-ID: <87bjwf6abf.fsf@draig.linaro.org> (raw)
In-Reply-To: <da769717-0823-45b4-8b1c-9fd2611d0092@linaro.org> (Pierrick Bouvier's message of "Thu, 9 Jan 2025 10:55:17 -0800")
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> On 1/9/25 09:06, Alex Bennée wrote:
>> This started as a clean-up to properly pass a Error handler to the
>> gdbserver_start so we could do the right thing for command line and
>> HMP invocations.
>> Now that we have cleaned up foreach_device_config_or_exit() in
>> earlier
>> patches we can further simplify by it by passing &error_fatal instead
>> of checking the return value. Having a return value is still useful
>> for HMP though so tweak the return to use a simple bool instead.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
>>
>
> <snip>
>
>> -static int gdbserver_open_port(int port)
>> +static int gdbserver_open_port(int port, Error **errp)
>
> Did you mean:
> static bool gdbserver_open_port...?
yes, yes I did. Will fix.
>
> With that,
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2025-01-09 19:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 17:05 [PATCH 00/22] maintainer updates for jan '25 (semihosting, gdb, plugins) Alex Bennée
2025-01-09 17:05 ` [PATCH 01/22] semihosting: add guest_error logging for failed opens Alex Bennée
2025-01-09 18:48 ` Pierrick Bouvier
2025-01-09 17:05 ` [PATCH 02/22] semihosting/uaccess: Briefly document returned values Alex Bennée
2025-01-09 17:06 ` [PATCH 03/22] semihosting/syscalls: Include missing 'exec/cpu-defs.h' header Alex Bennée
2025-01-09 17:06 ` [PATCH 04/22] semihosting/uaccess: Include missing 'exec/cpu-all.h' header Alex Bennée
2025-01-09 17:06 ` [PATCH 05/22] semihosting/arm-compat: Include missing 'cpu.h' header Alex Bennée
2025-01-09 17:06 ` [PATCH 06/22] semihosting/console: Avoid including 'cpu.h' Alex Bennée
2025-01-09 17:06 ` [PATCH 07/22] semihosting/meson: Build config.o and console.o once Alex Bennée
2025-01-09 17:06 ` [PATCH 08/22] system/vl: more error exit into config enumeration code Alex Bennée
2025-01-09 18:49 ` Pierrick Bouvier
2025-01-10 7:34 ` Philippe Mathieu-Daudé
2025-01-10 15:03 ` Richard Henderson
2025-01-09 17:06 ` [PATCH 09/22] system: squash usb_parse into a single function Alex Bennée
2025-01-09 17:30 ` Philippe Mathieu-Daudé
2025-01-09 17:06 ` [PATCH 10/22] system: propagate Error to gdbserver_start (and other device setups) Alex Bennée
2025-01-09 18:55 ` Pierrick Bouvier
2025-01-09 19:45 ` Alex Bennée [this message]
2025-01-09 22:27 ` Philippe Mathieu-Daudé
2025-01-10 11:54 ` Alex Bennée
2025-01-10 21:05 ` Pierrick Bouvier
2025-01-09 17:06 ` [PATCH 11/22] tests/tcg/plugins/insn: remove unused callback parameter Alex Bennée
2025-01-09 17:06 ` [PATCH 12/22] contrib/plugins/howvec: ensure we don't regress if this plugin is extended Alex Bennée
2025-01-09 17:06 ` [PATCH 13/22] tests/tcg/plugins/syscall: fix 32-bit build Alex Bennée
2025-01-09 17:06 ` [PATCH 14/22] tests/tcg/plugins/mem: " Alex Bennée
2025-01-09 17:06 ` [PATCH 15/22] contrib/plugins/stoptrigger: " Alex Bennée
2025-01-09 17:06 ` [PATCH 16/22] contrib/plugins/cache: " Alex Bennée
2025-01-09 17:06 ` [PATCH 17/22] contrib/plugins/hotblocks: " Alex Bennée
2025-01-09 17:06 ` [PATCH 18/22] contrib/plugins/cflow: " Alex Bennée
2025-01-09 17:06 ` [PATCH 19/22] contrib/plugins/hwprofile: " Alex Bennée
2025-01-09 17:06 ` [PATCH 20/22] contrib/plugins/hotpages: " Alex Bennée
2025-01-09 17:06 ` [PATCH 21/22] configure: reenable plugins by default for 32-bit hosts Alex Bennée
2025-01-09 17:06 ` [PATCH 22/22] accel/tcg: also suppress asynchronous IRQs for cpu_io_recompile Alex Bennée
2025-01-09 18:48 ` Pierrick Bouvier
2025-01-10 15:02 ` Richard Henderson
2025-01-11 15:09 ` Julian Ganz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjwf6abf.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=dave@treblig.org \
--cc=erdnaxe@crans.org \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.