Re: [PATCH v2 0/5] Add support for USB DFU boot on AM62Px

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Siddharth,

Thank you for the series.

On mer., déc. 18, 2024 at 18:15, Siddharth Vadapalli <s-vadapalli@ti.com> wrote:

> Hello,
>
> This series add support for USB DFU boot on TI's AM62Px SoC which has
> two instances of USB Controllers, of which the USB0 instance of USB
> which is a DWC3 USB Controller is used for USB DFU Boot:
> ROM => tiboot3.bin => tispl.bin => u-boot.img

>
> v1 of this series is at:
> https://patchwork.ozlabs.org/project/uboot/cover/20241217131658.2920799-1-s-vadapalli@ti.com/
> Changes since v1:
> - Dropped the first patch of the v1 series since its equivalent has been
>   posted by Jonathan Humphreys <j-humphreys@ti.com> at:
>   https://patchwork.ozlabs.org/project/uboot/patch/20241217204835.3312765-1-j-humphreys@ti.com/
> - Based on the feedback from Mattijs Korpershoek on the second patch of
>   the v1 series, the patches in this series have been updated. More
>   details regarding the changes have been described below the tearline
>   of the respective patches.
> - Collected Reviewed-by tags.

I have tested this on the AM62Px SK EVM. I did *not* apply the
dependency (20241217204835.3312765-1-j-humphreys@ti.com) and it worked
fine for me:

I did:
$ snagrecover -s am625 -f ./am62px-sk-evm.yaml

Boot logs:
https://paste.debian.net/1340393/

Also tested that I could enumerate the board with "fastboot".

Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>


>
> NOTE: I did *not* collect the Tested-by tag since this series has
> significant changes when compared to the v1 series. Though I have tested
> this series before posting it, I intend to get a Tested-by on this v2
> series itself after it gets tested.
>
> Series is based on commit
> 3b3c7280b82 smbios: address build warning
> of the next branch of U-Boot.
>
> NOTE: Series *depends* on:
>   https://patchwork.ozlabs.org/project/uboot/patch/20241217204835.3312765-1-j-humphreys@ti.com/
> since the corresponding patch has been dropped in this series when
> compared with the v1 of this series.
>
> The USB DFU config fragments for AM62x are to be re-used for enabling
> USB DFU boot on AM62Px as follows:
> R5  => am62px_evm_r5_defconfig + am62x_r5_usbdfu.config
> A53 => am62px_evm_a53_defconfig + am62x_a53_usbdfu.config
>
> Series has been tested on AM62P5-SK. Logs validating USB DFU boot on
> AM62P5-SK with this series:
> https://gist.github.com/Siddharth-Vadapalli-at-TI/d70cff3bfff53ef094d3a775e44f84c7
>
> Since am62px_evm_a53_defconfig has significant changes in this series,
> SD Boot has also been validated on AM62P5-SK with the
> am62px_evm_a53_defconfig of this series. Logs for the same are at:
> https://gist.github.com/Siddharth-Vadapalli-at-TI/971df121c8b69a2b8fb17f1c585ee0f4
>
> Series has also been validated on AM625-SK to ensure that the changes
> made to "am62x_r5_usbdfu.config" config fragment being used by AM625-SK
> for USB DFU boot do not cause a regression on AM625-SK w.r.t. USB DFU
> boot. Logs validating USB DFU Boot on AM625-SK with this series:
> https://gist.github.com/Siddharth-Vadapalli-at-TI/627c69150c34171b065204839c410e92
>
> Regards,
> Siddharth.
>
> Siddharth Vadapalli (5):
>   board: ti: am62px: env: include environment for DFU Boot
>   configs: am62x_r5_usbdfu: extend for AM62Px
>   configs: am62px_evm_a53_defconfig: enable USB DFU support
>   arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot
>   doc: board: document support for USB DFU boot on AM62Px SoC
>
>  arch/arm/dts/k3-am62p5-sk-u-boot.dtsi | 10 +++++++++
>  board/ti/am62px/am62px.env            |  5 +++--
>  configs/am62px_evm_a53_defconfig      | 24 +--------------------
>  configs/am62x_r5_usbdfu.config        |  3 +++
>  doc/board/ti/am62px_sk.rst            | 31 +++++++++++++++++++++++++++
>  5 files changed, 48 insertions(+), 25 deletions(-)
>
> -- 
> 2.43.0