From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5261A1BD028; Wed, 13 Nov 2024 09:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731488834; cv=none; b=Xmq1dIpkh3vwLNveZtwPxP5YT7RRhbHWaAIZXIhMXMMjCOPk1Xysu01egUmniDfkrHS2ic0wuNMqNbOxHyhdAJHYTzdmr1RC+UCcC8UYh9MIvwBTZBYnIBltgtF319yOPYo4ft3cVsXzcp0VWNtLw8D5e45EXZcVzz0QIokvYt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731488834; c=relaxed/simple; bh=gItS4ct+EOxG20yTUb1Sp9O+9wuwU7KGiBD97mPueXU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=lTQEIeqsjmxEgngOEEofOT8PHykc5CRnwmc2lp+Cjvt0C1yq4qUh/r+xBTlxQN9kgfrZ7I5yB9rZl0EtbVR639ampY2DBMJj8ZEcnxMtmI0xa/vXNygVPCSzr418CBW4JisTWIpf8rDmH1e0mPOkMc8PKoc4DMAhfKdYUhgpZgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=G2qmxmKc; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="G2qmxmKc" Received: by mail.gandi.net (Postfix) with ESMTPSA id 25131E0003; Wed, 13 Nov 2024 09:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1731488829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gItS4ct+EOxG20yTUb1Sp9O+9wuwU7KGiBD97mPueXU=; b=G2qmxmKcMURoRlGS4cfajPcrtQ5kTfsrSA9Tm4QY2j0/8O3lfNfFlnAMvavJdzc/RgV5WJ ARZAP1h19/6Bno5A1TJ9YMJ3lSZFd3m4vDXS40nLndb88SyaKRqfWN7Pt0f6UUpXpwTXcA fzB/qbR6vNiBtgZSz54VVWhc9yq+o+PQPTGpP1LcCGboKqPThjB307C3cNoK9Tz5YZqEkl 25Ym2aJ5A0mpMIg6I3YAbgtaIS3MgL+7suC8spzmARmiy719+lN7aQnyLQXIX7Cqj1SAl9 stL+IE1slGPQxlrDBQeTDTOztDw1rPDAczn33twZvcqOzT2Brq0KlEbNJvNyZg== From: Miquel Raynal To: Md Sadre Alam Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver In-Reply-To: <374ea155-0970-38bd-470f-cc440ca0bab5@quicinc.com> (Md Sadre Alam's message of "Tue, 12 Nov 2024 17:45:07 +0530") References: <20241030121919.865716-1-quic_mdalam@quicinc.com> <20241030121919.865716-3-quic_mdalam@quicinc.com> <871pzh397j.fsf@bootlin.com> <374ea155-0970-38bd-470f-cc440ca0bab5@quicinc.com> User-Agent: mu4e 1.12.1; emacs 29.4 Date: Wed, 13 Nov 2024 10:07:08 +0100 Message-ID: <87bjyjsds3.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hello, On 12/11/2024 at 17:45:07 +0530, Md Sadre Alam wr= ote: > On 11/12/2024 12:00 AM, Miquel Raynal wrote: >> On 30/10/2024 at 17:49:13 +0530, Md Sadre Alam = wrote: >>=20 >>> cleanup qcom_nandc driver as below >> Perform a global cleanup of the Qualcomm NAND controller driver with >> the >> following improvements: > Ok >>> >>> - Remove register value indirection api >> API > Ok >>=20 >>> >>> - Remove set_reg() api >> API > Ok >>=20 >>> >>> - Convert read_loc_first & read_loc_last macro to function >> functions > Ok >>=20 >>> >>> - Renamed multiple variables >> Rename > Ok In general when the main answer is "okay", you can probably just say a sentence like "thanks for the comments I'll take them into account", without answering to each and every comment. This way, it will be easier for me to catch if you have further remarks. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73379D41C1E for ; Wed, 13 Nov 2024 09:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v3aSq5/hmVzAgeTQ776Uz9QO3racDDyUyBH9amUk2ds=; b=SSLk7Bdf82W1C4 IY9y4WMwaBwjnjR7YIH8dsQmJd1eTXX9qCyMlaELbb0Sp7BtSQDMb4fStT/+ZTfUj87DkXXrdWJgQ jTKQhs/6p6d+faoLy1e3yA+0RTPAmFHq56uZWWpzYFDZGZ57mYK48Q0SG2yP7Knlzx+IOS8rtLBC3 +/xrk+BEy3KY4yI8gRTxxhHJoJLGLyNsM4lZHu/XnuXx03Tx52ZhyEItGouJWO0ZnmNX0KRoHmaWF +xjuY3mBcQnNXrH0G8THa2cK/y+okpe0I3Afr82p/QmmaJAcSieXx2auiZ7YCy1Z2Qq5av1AJuSVL Gx0tlHZg44REwlRS1lmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tB9N2-00000006CH3-0T0c; Wed, 13 Nov 2024 09:09:04 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tB9LD-00000006By4-2nxJ for linux-mtd@lists.infradead.org; Wed, 13 Nov 2024 09:07:13 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 25131E0003; Wed, 13 Nov 2024 09:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1731488829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gItS4ct+EOxG20yTUb1Sp9O+9wuwU7KGiBD97mPueXU=; b=G2qmxmKcMURoRlGS4cfajPcrtQ5kTfsrSA9Tm4QY2j0/8O3lfNfFlnAMvavJdzc/RgV5WJ ARZAP1h19/6Bno5A1TJ9YMJ3lSZFd3m4vDXS40nLndb88SyaKRqfWN7Pt0f6UUpXpwTXcA fzB/qbR6vNiBtgZSz54VVWhc9yq+o+PQPTGpP1LcCGboKqPThjB307C3cNoK9Tz5YZqEkl 25Ym2aJ5A0mpMIg6I3YAbgtaIS3MgL+7suC8spzmARmiy719+lN7aQnyLQXIX7Cqj1SAl9 stL+IE1slGPQxlrDBQeTDTOztDw1rPDAczn33twZvcqOzT2Brq0KlEbNJvNyZg== From: Miquel Raynal To: Md Sadre Alam Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver In-Reply-To: <374ea155-0970-38bd-470f-cc440ca0bab5@quicinc.com> (Md Sadre Alam's message of "Tue, 12 Nov 2024 17:45:07 +0530") References: <20241030121919.865716-1-quic_mdalam@quicinc.com> <20241030121919.865716-3-quic_mdalam@quicinc.com> <871pzh397j.fsf@bootlin.com> <374ea155-0970-38bd-470f-cc440ca0bab5@quicinc.com> User-Agent: mu4e 1.12.1; emacs 29.4 Date: Wed, 13 Nov 2024 10:07:08 +0100 Message-ID: <87bjyjsds3.fsf@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_010711_988203_45DD7A5E X-CRM114-Status: UNSURE ( 6.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiAxMi8xMS8yMDI0IGF0IDE3OjQ1OjA3ICswNTMwLCBNZCBTYWRyZSBBbGFtIDxx dWljX21kYWxhbUBxdWljaW5jLmNvbT4gd3JvdGU6Cgo+IE9uIDExLzEyLzIwMjQgMTI6MDAgQU0s IE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4+IE9uIDMwLzEwLzIwMjQgYXQgMTc6NDk6MTMgKzA1MzAs IE1kIFNhZHJlIEFsYW0gPHF1aWNfbWRhbGFtQHF1aWNpbmMuY29tPiB3cm90ZToKPj4gCj4+PiBj bGVhbnVwIHFjb21fbmFuZGMgZHJpdmVyIGFzIGJlbG93Cj4+IFBlcmZvcm0gYSBnbG9iYWwgY2xl YW51cCBvZiB0aGUgUXVhbGNvbW0gTkFORCBjb250cm9sbGVyIGRyaXZlciB3aXRoCj4+IHRoZQo+ PiBmb2xsb3dpbmcgaW1wcm92ZW1lbnRzOgo+IE9rCj4+Pgo+Pj4gLSBSZW1vdmUgcmVnaXN0ZXIg dmFsdWUgaW5kaXJlY3Rpb24gYXBpCj4+IEFQSQo+IE9rCj4+IAo+Pj4KPj4+IC0gUmVtb3ZlIHNl dF9yZWcoKSBhcGkKPj4gQVBJCj4gT2sKPj4gCj4+Pgo+Pj4gLSBDb252ZXJ0IHJlYWRfbG9jX2Zp cnN0ICYgcmVhZF9sb2NfbGFzdCBtYWNybyB0byBmdW5jdGlvbgo+PiBmdW5jdGlvbnMKPiBPawo+ PiAKPj4+Cj4+PiAtIFJlbmFtZWQgbXVsdGlwbGUgdmFyaWFibGVzCj4+IFJlbmFtZQo+IE9rCgpJ biBnZW5lcmFsIHdoZW4gdGhlIG1haW4gYW5zd2VyIGlzICJva2F5IiwgeW91IGNhbiBwcm9iYWJs eSBqdXN0IHNheSBhCnNlbnRlbmNlIGxpa2UgInRoYW5rcyBmb3IgdGhlIGNvbW1lbnRzIEknbGwg dGFrZSB0aGVtIGludG8gYWNjb3VudCIsCndpdGhvdXQgYW5zd2VyaW5nIHRvIGVhY2ggYW5kIGV2 ZXJ5IGNvbW1lbnQuIFRoaXMgd2F5LCBpdCB3aWxsIGJlIGVhc2llcgpmb3IgbWUgdG8gY2F0Y2gg aWYgeW91IGhhdmUgZnVydGhlciByZW1hcmtzLgoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBk aXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LW10ZC8K