All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: tkuw584924@gmail.com
Cc: linux-mtd@lists.infradead.org,  richard@nod.at,  vigneshr@ti.com,
	tudor.ambarus@linaro.org,  pratyush@kernel.org,
	 mwalle@kernel.org, kr.kim@skyhighmemory.com,
	 zhi.feng@skyhighmemory.com, Bacem.Daassi@infineon.com,
	 Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH 1/2] mtd: spinand: Introduce a way to avoid raw access
Date: Mon, 11 Nov 2024 19:54:47 +0100	[thread overview]
Message-ID: <87bjylsirs.fsf@bootlin.com> (raw)
In-Reply-To: <81c9caf04c94cba1a5ae4ba79dd09e0789583fcd.1730340421.git.Takahiro.Kuwano@infineon.com> (tkuw's message of "Thu, 31 Oct 2024 11:21:54 +0900")

Hi,

On 31/10/2024 at 11:21:54 +09, tkuw584924@gmail.com wrote:

> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>
> SkyHigh spinand device has ECC enable bit in configuration register but
> it must be always enabled. If ECC is disabled, read and write ops
> results in undetermined state. For such devices, a way to avoid raw
> access is needed.
>
> Introduce SPINAND_NO_RAW_ACCESS flag to advertise the device does not
> support raw access. Read and write page in raw mode for the device
> returns error.
>
> Checking and marking BBM need to be performed with ECC enabled to read
> and write the BBM correctly.

I see your point but I'm a bit puzzled by how it's being done.

First, you disregard completely the isbad() and markbad()
situations. Please have look into that because these functions are
broken with your devices.

Second, what about adding this detail to the ondie ECC engine? You could
simply return an error from there, so basically a single (or maybe two)
changes overall.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-11-11 18:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  2:21 [PATCH 0/2] mtd: spinand: Add support for SkyHigh S35ML-3 family tkuw584924
2024-10-31  2:21 ` [PATCH 1/2] mtd: spinand: Introduce a way to avoid raw access tkuw584924
2024-11-11 18:54   ` Miquel Raynal [this message]
2024-11-13  2:06     ` Takahiro Kuwano
2024-11-13  9:11       ` Miquel Raynal
2024-11-13 10:51         ` Takahiro Kuwano
2024-10-31  2:21 ` [PATCH 2/2] mtd: spinand: Add support for SkyHigh S35ML-3 family tkuw584924
2024-11-11 18:49   ` Miquel Raynal
2024-11-11 18:44 ` [PATCH 0/2] " Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjylsirs.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=Bacem.Daassi@infineon.com \
    --cc=Takahiro.Kuwano@infineon.com \
    --cc=kr.kim@skyhighmemory.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tkuw584924@gmail.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    --cc=zhi.feng@skyhighmemory.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.