All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org,  berrange@redhat.com,
	alejandro.zeise@seagate.com,  peter.maydell@linaro.org
Subject: Re: [PATCH] crypto/hash-afalg: Fix broken build
Date: Thu, 17 Oct 2024 09:58:48 +0200	[thread overview]
Message-ID: <87bjzjcg93.fsf@pond.sub.org> (raw)
In-Reply-To: <0a727cfe-af7c-4838-9336-2a6b2b555b8e@redhat.com> ("Cédric Le Goater"'s message of "Thu, 17 Oct 2024 08:54:04 +0200")

Cédric Le Goater <clg@redhat.com> writes:

> On 10/17/24 08:47, Markus Armbruster wrote:
>> Fux build broken by semantic conflict with commit
>> 8f525028bc6 (qapi/crypto: Rename QCryptoAFAlg to QCryptoAFAlgo).
>> Fixes: 90c3dc60735a (crypto/hash-afalg: Implement new hash API)
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> My bad :/ Obviously, I didn't catch this at compile time, nor did CI.

Not blaming you; this is something CI should catch.  How could we close
the CI gap?

> Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks!



  reply	other threads:[~2024-10-17  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  6:47 [PATCH] crypto/hash-afalg: Fix broken build Markus Armbruster
2024-10-17  6:54 ` Cédric Le Goater
2024-10-17  7:58   ` Markus Armbruster [this message]
2024-10-17  8:11   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjzjcg93.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=alejandro.zeise@seagate.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.