From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Tejas Vipin <tejasvipin76@gmail.com>,
Laurent.pinchart@ideasonboard.com, patrik.r.jakobsson@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
Date: Thu, 12 Sep 2024 14:25:40 +0300 [thread overview]
Message-ID: <87bk0tgll7.fsf@intel.com> (raw)
In-Reply-To: <57016d01-4525-4685-b029-41e03b0abbda@suse.de>
On Thu, 12 Sep 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Hi
>
> Am 12.09.24 um 11:38 schrieb Jani Nikula:
>> On Thu, 12 Sep 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>> Am 12.09.24 um 10:56 schrieb Jani Nikula:
>>>> Moreover, in this case .detect() only detects digital displays as
>>>> reported by EDID. If you postpone that to .get_modes(), the probe helper
>>>> will still report connected, and invent non-EDID fallback modes. The
>>>> behaviour changes.
>>> The change in behavior is intentional, because the current test seems
>>> arbitrary. Does the driver not work with analog outputs?
>> Not on a DVI/HDMI port. Same with i915.
>>
>> That's possibly the only way to distinguish a DVI-A display connected to
>> DVI-D source.
>
> That's a detect failure, but IMHO our probe helpers should really handle
> this case.
How? Allow returning detect failures from .get_modes()?
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-12 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 18:06 [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi Tejas Vipin
2024-09-12 7:19 ` Thomas Zimmermann
2024-09-12 8:48 ` Jani Nikula
2024-09-12 8:56 ` Jani Nikula
2024-09-12 9:26 ` Thomas Zimmermann
2024-09-12 9:38 ` Jani Nikula
2024-09-12 10:45 ` Thomas Zimmermann
2024-09-12 11:25 ` Jani Nikula [this message]
2024-09-12 13:10 ` Thomas Zimmermann
2024-09-12 13:25 ` Jani Nikula
2024-09-12 9:18 ` Thomas Zimmermann
2024-09-12 9:30 ` Jani Nikula
2024-09-12 11:08 ` Thomas Zimmermann
2024-09-12 13:30 ` Ville Syrjälä
2024-09-12 14:29 ` Tejas Vipin
2024-09-23 9:36 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk0tgll7.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=tejasvipin76@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.