Re: [PATCH] wireless: ath9k: eeprom: remove platform data

[Kalle Valo <kvalo@kernel.org>]

Rosen Penev <rosenp@gmail.com> writes:

> On Wed, Sep 4, 2024 at 10:56 AM Rosen Penev <rosenp@gmail.com> wrote:
>
>>
>> On Wed, Sep 4, 2024 at 7:53 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>> >
>> > On 9/4/2024 1:05 AM, Kalle Valo wrote:
>> > > Rosen Penev <rosenp@gmail.com> writes:
>> > >
>> > >> There are no more board files defining platform data for this driver and
>> > >> eeprom support through NVMEM has already been implemented. No need to
>> > >> keep this old functionality around.
>> > >>
>> > >> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>> > >> ---
>> > >>  As an aside, the last user of this functionality downstream in OpenWrt
>> > >>  has been removed: https://github.com/openwrt/openwrt/commit/7ac8279bd
>> > >>
>> > >>  drivers/net/wireless/ath/ath9k/eeprom.c | 12 ------------
>> > >>  1 file changed, 12 deletions(-)
>> > >>
>> > >> diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c
>> > >> index efb7889142d4..df58dc02e104 100644
>> > >> --- a/drivers/net/wireless/ath/ath9k/eeprom.c
>> > >> +++ b/drivers/net/wireless/ath/ath9k/eeprom.c
>> > >> @@ -15,7 +15,6 @@
>> > >>   */
>> > >>
>> > >>  #include "hw.h"
>> > >> -#include <linux/ath9k_platform.h>
>> > >
>> > > What about the file include/linux/ath9k_platform.h? That should be also
>> > > removed, right?
>> >
>> > That file is still used by other functionality (see init.c, btcoex.c)
>> > But seems that at a minimum unused eeprom-related stuff should be removed from
>> > struct ath9k_platform_data.
>> That's why I kept my changes to a minimum. I don't yet want to axe the
>> other stuff. OpenWrt has a ton of non upstreamed patches for ath9k,
>> some probably relying on ath9k_platform_data. I need to do real
>> careful analysis to remove the rest.
>> >
>> > Please review that all of the platform-related code in init.c is still needed,
>> > especially code related to eeprom support.
>
> That's handled with nvmem and OF (if applicable).
>
> Anyway, I split up the removal in 4 patches. of_init needs some extra
> functionality to match platform_device.
>
> Does Documentation need to go in its own commit?

I don't know what Documentation changes you are doing but usually it's
good to make changes to Documentation in separate patches.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches