From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Bennée Date: Thu, 08 Aug 2024 13:00:00 +0100 Subject: [PATCH v12 13/84] KVM: Annotate that all paths in hva_to_pfn() might sleep In-Reply-To: <20240726235234.228822-14-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:22 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-14-seanjc@google.com> Message-ID: <87bk23ql6n.fsf@draig.linaro.org> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sean Christopherson writes: > Now that hva_to_pfn() no longer supports being called in atomic context, > move the might_sleep() annotation from hva_to_pfn_slow() to > hva_to_pfn(). The commentary for hva_to_pfn_fast disagrees. /* * The fast path to get the writable pfn which will be stored in @pfn, * true indicates success, otherwise false is returned. It's also the * only part that runs if we can in atomic context. */ static bool hva_to_pfn_fast(struct kvm_follow_pfn *kfp, kvm_pfn_t *pfn) At which point did it loose the ability to run in the atomic context? I couldn't work it out from the commits. > > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 84c73b4fc804..03af1a0090b1 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2807,8 +2807,6 @@ static int hva_to_pfn_slow(unsigned long addr, bool *async, bool write_fault, > struct page *page; > int npages; > > - might_sleep(); > - > if (writable) > *writable = write_fault; > > @@ -2947,6 +2945,8 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool interruptible, bool *async, > kvm_pfn_t pfn; > int npages, r; > > + might_sleep(); > + > if (hva_to_pfn_fast(addr, write_fault, writable, &pfn)) > return pfn; -- Alex Benn?e Virtualisation Tech Lead @ Linaro From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD8E18C348 for ; Thu, 8 Aug 2024 12:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118407; cv=none; b=hvK2zvMCmzV4pC2CQWGvUgIlEQf3DFwMb5KbWenhgMawuoIdLeXCtbZ7LjdNWZEz4kd2U1L37Tvd+XKEZ1AcraBsfTS8COUiD7jdoIUcLvVnC/az8dIlfSKC2JRLOtpF/n316LMdXPHoPLf5WTKQ8qbZSb/xquEwFkel4WYi+bM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118407; c=relaxed/simple; bh=4VJkCGOnJpRwR4YKBH81A1uxdWFs9jOzqwkiDCMslRY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=COWwSVER0HqJZuoqv7GgFE4u01OdI3wz0L//ZQdjvuWf3sVkVXfQ3FtYgmi6myh2YHhpn34e0kvInHf6Lsbr1NSalP+mAo6UAxhCuu9sLRWgzES3GjASLRAKcSOidI6zMriwld2f9Qg9ryn6zPIarhCo/7sc/s0/fWGgEF0VFC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ddkuFE9F; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ddkuFE9F" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3685b3dbcdcso489400f8f.3 for ; Thu, 08 Aug 2024 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723118403; x=1723723203; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=ddkuFE9FINzia0qQVVaAQtZuEXNAIekNuYkVjCLYxZyvoCdYq1EEgTZx2+1AOrzHqt +31SUlBnAGOJ3JBSQYO66KKvQvP5QfHjsLIzws812nAW0O5c5nVf6fCLOO1CvOPDh5oK Lzw6NNaIXWLRKVugiwcSxG/lfgdfWXCaSQBjhhslNoOO47IsjeA7Jkkp3WP2zljECXlP pSiWXIF6m7UxwyEqa1Gl3LCvcBuqYhHXMdQI6BMMYHT6Ux1CP9a7iWJ5HW/BiPZEJa0w Lo/G490AaghDCjLxE4LDa3KBmPgjeaytGziiOh25PJ7sBROW/mXaPdMqBcBAi8ZRahgb +Z1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723118403; x=1723723203; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=GWnRU1iGYc9ImjDjojUN99+EPmtq/+DqbmBrc6/GgDhjs/1lyugWCWL0UxJw6iIbMu lGtBLkigJkC9s+VV4oWTcW/ZKpEv+30NMLkITI7R7MQ0H4+U7qYUOC2IJt+wOU0nyzX2 QTyVc1BW3Tybcoi6ADTIRrzeG88ldHnaNw/QU2C66RUODK+RqUKdcaDa8eMD1/ZGET65 Kc9GZhn4eJ0qG9fJUUvkZWFbeeDRu+PXUiYr5RDSQPEss3dUggDLvrJMyWjhuCg3n+81 FsAnYbSJik/wcO6HvZkeMapYNKgzN1dRaRrpwxeJgfBeWo3WWLXUIGmzxDcngwLByNyQ e+4g== X-Forwarded-Encrypted: i=1; AJvYcCUCFGxdCfAmIbjA/N7KoXohLVY6Kt5SKCf3BkGvhI80KotOvDU1K78Q1R05up48yst2L/O7K82pTgA83cm6vlTFCNP+wcoy X-Gm-Message-State: AOJu0Yx8NTt9lXQ+qyJM3kxd48+DnIbwCcSEirOC2f4lKtIKNstK886C BbCbZvpjlW3shNIJISDcu5tGNKhpaqnxXae+j4+00G1oD5ClouWfxtPGFmNHIIk= X-Google-Smtp-Source: AGHT+IHHX2fBYyF3bzrkIN6FI+lRc2WcNWD9HizbtFbwpwdbf6zDJoYFHOfDyhNaZKL5sM+Jijm6XQ== X-Received: by 2002:a5d:698f:0:b0:367:8fee:443b with SMTP id ffacd0b85a97d-36d27561461mr1129489f8f.41.1723118402280; Thu, 08 Aug 2024 05:00:02 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27156c8asm1700288f8f.24.2024.08.08.05.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 05:00:01 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 751635F769; Thu, 8 Aug 2024 13:00:00 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 13/84] KVM: Annotate that all paths in hva_to_pfn() might sleep In-Reply-To: <20240726235234.228822-14-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:22 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-14-seanjc@google.com> Date: Thu, 08 Aug 2024 13:00:00 +0100 Message-ID: <87bk23ql6n.fsf@draig.linaro.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Christopherson writes: > Now that hva_to_pfn() no longer supports being called in atomic context, > move the might_sleep() annotation from hva_to_pfn_slow() to > hva_to_pfn(). The commentary for hva_to_pfn_fast disagrees. /* * The fast path to get the writable pfn which will be stored in @pfn, * true indicates success, otherwise false is returned. It's also the * only part that runs if we can in atomic context. */ static bool hva_to_pfn_fast(struct kvm_follow_pfn *kfp, kvm_pfn_t *pfn) At which point did it loose the ability to run in the atomic context? I couldn't work it out from the commits. > > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 84c73b4fc804..03af1a0090b1 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2807,8 +2807,6 @@ static int hva_to_pfn_slow(unsigned long addr, bool= *async, bool write_fault, > struct page *page; > int npages; >=20=20 > - might_sleep(); > - > if (writable) > *writable =3D write_fault; >=20=20 > @@ -2947,6 +2945,8 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool inter= ruptible, bool *async, > kvm_pfn_t pfn; > int npages, r; >=20=20 > + might_sleep(); > + > if (hva_to_pfn_fast(addr, write_fault, writable, &pfn)) > return pfn; --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C39B2C3DA4A for ; Thu, 8 Aug 2024 12:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZFFamuelGCBTS+DUuR9F03/jbI0oj77rsbRuqHHnQQE=; b=hufzVMbDW/05S1 8ZbDfYkKV9HHCCU1Zmt0ZNMS6YW3koMQsXgfwOUeNnhjsLBi4o3NcNafPN+FekzpuCCRaLqBN7i4s XJgLKwlJ5uJ7U1khlVxhQPdZ8k5EUhyzDyCMxLmqfIXkfWmNSzRcRMrz1WCMTjgeLzpYxRjVqX/s8 5JsUDOD36WxqZ711qSCqbLs1WWcydO/s6ajypdCrjDk7PemJbedP5uZRm+iNYdRRugCEGl/Ks/0PO rT8CQfJyDUs2zQXTQtRsvzwj1JL8DORK0VBQT46gfmMMTK/xjFjBaWW/Y9QBGve3fQ/kS2OJ1P8Zc 2OK8DyzSDf7Q0BSkdeag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc1ow-000000088I0-1sad; Thu, 08 Aug 2024 12:00:42 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc1oL-00000008898-0cV7 for linux-riscv@lists.infradead.org; Thu, 08 Aug 2024 12:00:07 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3685b3dbcdcso489402f8f.3 for ; Thu, 08 Aug 2024 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723118403; x=1723723203; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=xNIitkLg7Hn52QZCVxNjF52WUwcVVhJsS7rrSHzxZK307WZbq/Xf6yd3YrIa3LFDIS U9lnTOWUeRhDsDfx4pzQNeSeWtSMpxhiez6XTb8sRebDM/SfXetaVZWNKz99X3OtBaaX ctmYWH3GTGP2IHZrWARu6+yiFMDeyYX1uJO0nutAc/kYpsrT6j1E877emeEtOCi7rKSp PoXnVzknSwqdoWcgZZwRneHwBDz2A2nTzk4fDzXRIvDKeFVI5n2CM81BisBe5WOHXeWS qufh+ZZzJ8o+VQqf7QTMAidEyyK+zpvbcpwvKe5Xj/kS3q6MSSNf8k1roflHxsLBWBCH qowA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723118403; x=1723723203; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=YwcZu5VdGPidnextQU8+5vC9DkpouxGOpHIPaGVXeuGtXeymBFRS0Y7LwMVfDlaPw8 rltnCWt+N0iQ3Wg5sY9v+BJ4xIXTwJzPyWGJ5EsIjHpuUSnFY/ATvOIQ3QtBn1Y0ULAp 6tdivf3pvgK8SHIXTzUdRy6mEzbOJzWtggVKOtzj1qPMUYTzU63Qy5Pk/SW9kwyQhb4a r2PfDftAy67Cb3tt0Sen+BDF7g6XE14y95y/mfU7PXvhClTKRF2yASzi7+IOvr7Psceh 9I+/s0+lR/u76yHWFXQl7W1XHNBKI4f8puHLIVoOkEnFdwUkDqN6IryPmy5fY9VOaz1n Zv3w== X-Forwarded-Encrypted: i=1; AJvYcCXISYzaJo3gqn1G8k4anNufI/1QC3hwT8XTMmirf3iERevONTakNRuSMBlx7vXW8poTJW/pyDYq1ldrd3wGFt38sP1HZWRvutP9toIiZ6FP X-Gm-Message-State: AOJu0YyV/GDnX/xOVUJxakM7exN98+1qLyPZ2CHZoz5zB36VxvqU7fvY E4y5AjzsFGaA1tjpC3yOaQxyFV907sR8ZIaP3G/ZW5aL2+a4IY21Fm7C8aw7KJE= X-Google-Smtp-Source: AGHT+IHHX2fBYyF3bzrkIN6FI+lRc2WcNWD9HizbtFbwpwdbf6zDJoYFHOfDyhNaZKL5sM+Jijm6XQ== X-Received: by 2002:a5d:698f:0:b0:367:8fee:443b with SMTP id ffacd0b85a97d-36d27561461mr1129489f8f.41.1723118402280; Thu, 08 Aug 2024 05:00:02 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27156c8asm1700288f8f.24.2024.08.08.05.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 05:00:01 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 751635F769; Thu, 8 Aug 2024 13:00:00 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 13/84] KVM: Annotate that all paths in hva_to_pfn() might sleep In-Reply-To: <20240726235234.228822-14-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:22 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-14-seanjc@google.com> Date: Thu, 08 Aug 2024 13:00:00 +0100 Message-ID: <87bk23ql6n.fsf@draig.linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_050005_198687_2FBB50C7 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org U2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+IHdyaXRlczoKCj4gTm93IHRo YXQgaHZhX3RvX3BmbigpIG5vIGxvbmdlciBzdXBwb3J0cyBiZWluZyBjYWxsZWQgaW4gYXRvbWlj IGNvbnRleHQsCj4gbW92ZSB0aGUgbWlnaHRfc2xlZXAoKSBhbm5vdGF0aW9uIGZyb20gaHZhX3Rv X3Bmbl9zbG93KCkgdG8KPiBodmFfdG9fcGZuKCkuCgpUaGUgY29tbWVudGFyeSBmb3IgaHZhX3Rv X3Bmbl9mYXN0IGRpc2FncmVlcy4KCiAgLyoKICAgKiBUaGUgZmFzdCBwYXRoIHRvIGdldCB0aGUg d3JpdGFibGUgcGZuIHdoaWNoIHdpbGwgYmUgc3RvcmVkIGluIEBwZm4sCiAgICogdHJ1ZSBpbmRp Y2F0ZXMgc3VjY2Vzcywgb3RoZXJ3aXNlIGZhbHNlIGlzIHJldHVybmVkLiAgSXQncyBhbHNvIHRo ZQogICAqIG9ubHkgcGFydCB0aGF0IHJ1bnMgaWYgd2UgY2FuIGluIGF0b21pYyBjb250ZXh0Lgog ICAqLwogIHN0YXRpYyBib29sIGh2YV90b19wZm5fZmFzdChzdHJ1Y3Qga3ZtX2ZvbGxvd19wZm4g KmtmcCwga3ZtX3Bmbl90ICpwZm4pCgpBdCB3aGljaCBwb2ludCBkaWQgaXQgbG9vc2UgdGhlIGFi aWxpdHkgdG8gcnVuIGluIHRoZSBhdG9taWMgY29udGV4dD8gSQpjb3VsZG4ndCB3b3JrIGl0IG91 dCBmcm9tIHRoZSBjb21taXRzLgoKPgo+IFNpZ25lZC1vZmYtYnk6IFNlYW4gQ2hyaXN0b3BoZXJz b24gPHNlYW5qY0Bnb29nbGUuY29tPgo+IC0tLQo+ICB2aXJ0L2t2bS9rdm1fbWFpbi5jIHwgNCAr Ky0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvdmlydC9rdm0va3ZtX21haW4uYyBiL3ZpcnQva3ZtL2t2bV9tYWluLmMK PiBpbmRleCA4NGM3M2I0ZmM4MDQuLjAzYWYxYTAwOTBiMSAxMDA2NDQKPiAtLS0gYS92aXJ0L2t2 bS9rdm1fbWFpbi5jCj4gKysrIGIvdmlydC9rdm0va3ZtX21haW4uYwo+IEBAIC0yODA3LDggKzI4 MDcsNiBAQCBzdGF0aWMgaW50IGh2YV90b19wZm5fc2xvdyh1bnNpZ25lZCBsb25nIGFkZHIsIGJv b2wgKmFzeW5jLCBib29sIHdyaXRlX2ZhdWx0LAo+ICAJc3RydWN0IHBhZ2UgKnBhZ2U7Cj4gIAlp bnQgbnBhZ2VzOwo+ICAKPiAtCW1pZ2h0X3NsZWVwKCk7Cj4gLQo+ICAJaWYgKHdyaXRhYmxlKQo+ ICAJCSp3cml0YWJsZSA9IHdyaXRlX2ZhdWx0Owo+ICAKPiBAQCAtMjk0Nyw2ICsyOTQ1LDggQEAg a3ZtX3Bmbl90IGh2YV90b19wZm4odW5zaWduZWQgbG9uZyBhZGRyLCBib29sIGludGVycnVwdGli bGUsIGJvb2wgKmFzeW5jLAo+ICAJa3ZtX3Bmbl90IHBmbjsKPiAgCWludCBucGFnZXMsIHI7Cj4g IAo+ICsJbWlnaHRfc2xlZXAoKTsKPiArCj4gIAlpZiAoaHZhX3RvX3Bmbl9mYXN0KGFkZHIsIHdy aXRlX2ZhdWx0LCB3cml0YWJsZSwgJnBmbikpCj4gIAkJcmV0dXJuIHBmbjsKCi0tIApBbGV4IEJl bm7DqWUKVmlydHVhbGlzYXRpb24gVGVjaCBMZWFkIEAgTGluYXJvCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QK bGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54F54C3DA4A for ; Thu, 8 Aug 2024 12:01:05 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=FmSN8Pcm; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WflxX05yrz2yMD for ; Thu, 8 Aug 2024 22:01:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=FmSN8Pcm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::430; helo=mail-wr1-x430.google.com; envelope-from=alex.bennee@linaro.org; receiver=lists.ozlabs.org) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WflwW0P0Vz2xg9 for ; Thu, 8 Aug 2024 22:00:09 +1000 (AEST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-369cb9f086aso502644f8f.0 for ; Thu, 08 Aug 2024 05:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723118403; x=1723723203; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=FmSN8PcmC9y+b/5Vab5vn8xiFLeujhtIBYbIVTRP/sND3VZyUPPIKoH6piKjmWK0Pd DjGKhgtQs61L+rqFD/ykQuPbBzU7uGIQDM+3bovhKob9CT9ubM/AxtJnpKr4KYBejAr0 IYvjQRWVU1ktnb04wmrF+weN4igu6cy3USATGE4sZJAOdyGPL6FAZV4aFlxCGTwCxrFL L+WdjTPGjgnCUUNB720/l9XdPdeLmEFVykgk3NbzI6LF5O0CjvYYUXmGPSPOlykc6Y+M eXGcFg1zqU3bJtsvATsi72SLBU5lZXPHKCo3SCqGKSmXx4b4eKXqlenR5JKkV7jC3tnK DZ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723118403; x=1723723203; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=c2RdDj4sI3iWeCSzKAb6QA1vCkLK/+Ebm5HNmGktNXMKhR1IenQn5Fh5Tar3mO+53E 4+769fpEmDNd4fXdnbd26PDy8ab6z03K3fc76jTNRmVtLTRrBkNYw+LfqW4OX15LVlWn 8QgfJMGSKjpKdCFsTRJy6oRDcBlXFrhKqS15BUitb6ufmzqsjhkt7/IK6Hcxx2fwgov0 E29ZWToxWLccJ7juz/YXaDYh7YCtJZIoFgIgsJGBOgYSRISTCyPnP6syi9et9IYjsWcg kJEQBD0X4e6peNGC1lu1CUYVP8QXPzGw+j8qHWVP+FvUuVsnlk2Gpn221XA2H5YzxGjM C+Xw== X-Forwarded-Encrypted: i=1; AJvYcCV2zLDWnw1Js2CvT2M6hArRqDC5glaFjHS4HmXIdmKCWIpqhEyXEF8T1g2bFKalARwiOFZKSZWocBXiZGr8+HW8AAQEkI4Q7VOeyJcR2g== X-Gm-Message-State: AOJu0YxgO9TrBLIW7QBgfj2CkWECeyv7hYwOg2ne+RgYcylR4TSSTmFQ 5g28tXx825bKYfN4LtCKqwxAphQX2ttuNOi0YWvl6LkVeAi6EHmX/RlFl+BXOmc= X-Google-Smtp-Source: AGHT+IHHX2fBYyF3bzrkIN6FI+lRc2WcNWD9HizbtFbwpwdbf6zDJoYFHOfDyhNaZKL5sM+Jijm6XQ== X-Received: by 2002:a5d:698f:0:b0:367:8fee:443b with SMTP id ffacd0b85a97d-36d27561461mr1129489f8f.41.1723118402280; Thu, 08 Aug 2024 05:00:02 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27156c8asm1700288f8f.24.2024.08.08.05.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 05:00:01 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 751635F769; Thu, 8 Aug 2024 13:00:00 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Subject: Re: [PATCH v12 13/84] KVM: Annotate that all paths in hva_to_pfn() might sleep In-Reply-To: <20240726235234.228822-14-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:22 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-14-seanjc@google.com> Date: Thu, 08 Aug 2024 13:00:00 +0100 Message-ID: <87bk23ql6n.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, David Matlack , linux-riscv@lists.infradead.org, Claudio Imbrenda , Janosch Frank , Marc Zyngier , Huacai Chen , Christian Borntraeger , Albert Ou , Bibo Mao , loongarch@lists.linux.dev, Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Oliver Upton , Palmer Dabbelt , David Stevens , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Sean Christopherson writes: > Now that hva_to_pfn() no longer supports being called in atomic context, > move the might_sleep() annotation from hva_to_pfn_slow() to > hva_to_pfn(). The commentary for hva_to_pfn_fast disagrees. /* * The fast path to get the writable pfn which will be stored in @pfn, * true indicates success, otherwise false is returned. It's also the * only part that runs if we can in atomic context. */ static bool hva_to_pfn_fast(struct kvm_follow_pfn *kfp, kvm_pfn_t *pfn) At which point did it loose the ability to run in the atomic context? I couldn't work it out from the commits. > > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 84c73b4fc804..03af1a0090b1 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2807,8 +2807,6 @@ static int hva_to_pfn_slow(unsigned long addr, bool= *async, bool write_fault, > struct page *page; > int npages; >=20=20 > - might_sleep(); > - > if (writable) > *writable =3D write_fault; >=20=20 > @@ -2947,6 +2945,8 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool inter= ruptible, bool *async, > kvm_pfn_t pfn; > int npages, r; >=20=20 > + might_sleep(); > + > if (hva_to_pfn_fast(addr, write_fault, writable, &pfn)) > return pfn; --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro