Re: [PATCH v1 3/4] test/py: introduce test for ab_dump command

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Dmitry,

Thank you for the patch.

On lun., juil. 29, 2024 at 17:39, Dmitry Rokosov <ddrokosov@salutedevices.com> wrote:

> Hello Simon,
>
> On Sun, Jul 28, 2024 at 01:36:05PM -0600, Simon Glass wrote:
>> Hi Dmitry,
>> 
>> On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov
>> <ddrokosov@salutedevices.com> wrote:
>> >
>> > The ab_dump command allows you to display ABC data directly on the
>> > U-Boot console. During an A/B test execution, this test verifies the
>> > accuracy of each field within the ABC data.
>> >
>> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
>> > ---
>> >  test/py/tests/test_android/test_ab.py | 23 +++++++++++++++++++++++
>> >  1 file changed, 23 insertions(+)
>> 
>> This looks good but please use lower-case hex.
>
> Thank you for the quick review!
>
> I will change it to lower-case hex in the next version.

With Simon's suggestion addressed:

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

>
> -- 
> Thank you,
> Dmitry