Re: [PATCH i-g-t] lib/xe/oa: Handle SIMD16_EU_PER_DSS

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 22 Jul 2024 12:07:17 -0700, Lucas De Marchi wrote:
>
> Handle SIMD16_EU_PER_DSS the same way EU_PER_DSS is. Since this function
> is mixing information from hwconfig and the topo query, this should be
> more correct as now the numbers from the query match the hwconfig.
>
> This fixes the assert triggering in the default case because
> SIMD16_EU_PER_DSS was not handled:
>
>	(xe_oa:4511) CRITICAL: Test assertion failure function xe_fill_topology_info, file ../lib/xe/xe_oa.c:532:
>	(xe_oa:4511) CRITICAL: Failed assertion: 0
>	(xe_oa:4511) CRITICAL: Last errno: 2, No such file or directory
>	Test xe_oa failed.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  lib/xe/xe_oa.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/xe/xe_oa.c b/lib/xe/xe_oa.c
> index 797458439..4764ed1fc 100644
> --- a/lib/xe/xe_oa.c
> +++ b/lib/xe/xe_oa.c
> @@ -521,6 +521,7 @@ xe_fill_topology_info(int drm_fd, uint32_t device_id, uint32_t *topology_size)
>			ptr += ptopo->subslice_stride;
>			break;
>		case DRM_XE_TOPO_EU_PER_DSS:
> +		case DRM_XE_TOPO_SIMD16_EU_PER_DSS:
>			for (i = 0; i < ptopo->max_subslices; i++) {
>				memcpy(ptr, topo->mask, ptopo->eu_stride);
>				ptr += ptopo->eu_stride;
> --
> 2.43.0
>