All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU
@ 2024-05-16 15:14 Nirmoy Das
  2024-05-16 16:22 ` Cavitt, Jonathan
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Nirmoy Das @ 2024-05-16 15:14 UTC (permalink / raw)
  To: intel-gfx
  Cc: dri-devel, Nirmoy Das, Andi Shyti, Janusz Krzysztofik,
	Jonathan Cavitt

The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick
correct caching mode.")' was not complete as for non LLC  sharing platforms
cpu read can happen from LLC which probably doesn't have the latest
changes made by GPU.

Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c
index 65a931ea80e9..3527b8f446fe 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c
@@ -196,7 +196,7 @@ static int verify_access(struct drm_i915_private *i915,
 	if (err)
 		goto out_file;
 
-	mode = intel_gt_coherent_map_type(to_gt(i915), native_obj, true);
+	mode = intel_gt_coherent_map_type(to_gt(i915), native_obj, false);
 	vaddr = i915_gem_object_pin_map_unlocked(native_obj, mode);
 	if (IS_ERR(vaddr)) {
 		err = PTR_ERR(vaddr);
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-05-17 12:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 15:14 [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU Nirmoy Das
2024-05-16 16:22 ` Cavitt, Jonathan
2024-05-16 18:44 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-05-17  7:39 ` [PATCH] " Jani Nikula
2024-05-17  8:40   ` Nirmoy Das
2024-05-17 11:53     ` Jani Nikula
2024-05-17 12:45       ` Nirmoy Das
2024-05-17  8:46 ` ✗ Fi.CI.IGT: failure for " Patchwork
2024-05-17 12:47   ` Nirmoy Das
2024-05-17 10:30 ` [PATCH] " Andi Shyti

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.