From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 565FFC3DA6E for ; Wed, 3 Jan 2024 10:54:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0FA65E7C; Wed, 3 Jan 2024 11:53:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0FA65E7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1704279237; bh=77H0xqiFdV9/ZbJDpHe1jpOV8nA4+iJC2Y0CgqaTvPo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TVRH9Hkl426GfhS2tUH1pWs6LOp3NsaTXGKCF+Cg30r77ZQ7msax283QLobD95MeB qU23wkjJ19Ge0dqv2pOf5KSewZIJYB6zRPDLcdEzmHsYVoA2opPbjdl4APoTgGQ6e4 jP18Tf0Y3XTB5kz62sO/6MNypKDSLj80gLoxpSa0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D676FF80570; Wed, 3 Jan 2024 11:53:25 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 601C1F80580; Wed, 3 Jan 2024 11:53:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 240A3F80424; Wed, 3 Jan 2024 11:50:28 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EFC87F80051 for ; Wed, 3 Jan 2024 11:50:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EFC87F80051 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WNPa+fMi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GwfWdUn1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WNPa+fMi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GwfWdUn1 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 601571FD11; Wed, 3 Jan 2024 10:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704279018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4wxXCY1XA5sZiJPe9cvdG0ludmPXkduZ1yrQ2KPpE7w=; b=WNPa+fMifSECdTIrV1WxIs4qiZq7PS35RKS09k97hVv7RuQC+OenR3Wfvc07Gs/GyJCMU0 1SQCPko0Ak2zeyXgojyhrEE/gAesUux7mSZ1QkXBufp8AZAdupI9q5cDAsMin4EiALSHvK 8hWJGgovw5OkS8IGWaURID42T1xXhe4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704279018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4wxXCY1XA5sZiJPe9cvdG0ludmPXkduZ1yrQ2KPpE7w=; b=GwfWdUn1QNWHsEE58qZ+GjLILa1hzocESF2tMQbOcWzrdkl6Vs4jYsRXrPJduyd3/BIBCo 8w3zk7+e+9bKjCBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704279018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4wxXCY1XA5sZiJPe9cvdG0ludmPXkduZ1yrQ2KPpE7w=; b=WNPa+fMifSECdTIrV1WxIs4qiZq7PS35RKS09k97hVv7RuQC+OenR3Wfvc07Gs/GyJCMU0 1SQCPko0Ak2zeyXgojyhrEE/gAesUux7mSZ1QkXBufp8AZAdupI9q5cDAsMin4EiALSHvK 8hWJGgovw5OkS8IGWaURID42T1xXhe4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704279018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4wxXCY1XA5sZiJPe9cvdG0ludmPXkduZ1yrQ2KPpE7w=; b=GwfWdUn1QNWHsEE58qZ+GjLILa1hzocESF2tMQbOcWzrdkl6Vs4jYsRXrPJduyd3/BIBCo 8w3zk7+e+9bKjCBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EC1B41340C; Wed, 3 Jan 2024 10:50:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id yjX9N+k7lWXDBwAAD6G6ig (envelope-from ); Wed, 03 Jan 2024 10:50:17 +0000 Date: Wed, 03 Jan 2024 11:50:17 +0100 Message-ID: <87bka2bsie.wl-tiwai@suse.de> From: Takashi Iwai To: Arnd Bergmann Cc: James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Stefan Binding , Arnd Bergmann , Dorian Cruveiller , Yang Yingliang , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: cs35l41: fix building without CONFIG_SPI In-Reply-To: <20240103102606.3742476-1-arnd@kernel.org> References: <20240103102606.3742476-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.05 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWELVE(0.00)[14]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,arndb.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[cirrus.com,opensource.cirrus.com,perex.cz,suse.com,arndb.de,gmail.com,huawei.com,alsa-project.org,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.74)[93.43%]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WNPa+fMi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GwfWdUn1 X-Rspamd-Queue-Id: 601571FD11 Message-ID-Hash: TAKZUQQMDNDLWUNH2UAEOSQSPDULHKUO X-Message-ID-Hash: TAKZUQQMDNDLWUNH2UAEOSQSPDULHKUO X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 03 Jan 2024 11:25:59 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_SPI is disabled, the driver produces unused-variable warning: > > sound/pci/hda/cs35l41_hda_property.c: In function 'generic_dsd_config': > sound/pci/hda/cs35l41_hda_property.c:181:28: error: unused variable 'spi' [-Werror=unused-variable] > 181 | struct spi_device *spi; > | ^~~ > sound/pci/hda/cs35l41_hda_property.c:180:27: error: unused variable 'cs_gpiod' [-Werror=unused-variable] > 180 | struct gpio_desc *cs_gpiod; > | ^~~~~~~~ > > Avoid these by turning the preprocessor contionals into equivalent C code, > which also helps readability. > > Fixes: 916d051730ae ("ALSA: hda: cs35l41: Only add SPI CS GPIO if SPI is enabled in kernel") > Signed-off-by: Arnd Bergmann Applied now. Thanks. Takashi