All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Leo Yan" <leo.yan@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: State of contrib/vhost-user-input?
Date: Tue, 24 Oct 2023 16:20:43 +0100	[thread overview]
Message-ID: <87bkco2ghz.fsf@linaro.org> (raw)
In-Reply-To: <87jzrc2ihe.fsf@linaro.org>


Alex Bennée <alex.bennee@linaro.org> writes:

> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>
>> Hi Alex
>>
>> On Mon, Oct 23, 2023 at 8:34 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>>
>>> Hi,
>>>
>>> I'm trying to get the contrib/vhost-user-input working but it exits
>>> during the boot up sequence:
>>>
<snip>
>>> Which looks like libvhost-user is expecting
>>> VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS to be negotiated and the
>>> resulting VHOST_USER_ADD_MEM_REG to be sent. How is this meant to work
>>> if the protocol feature isn't negotiated?
>>
>>
>> How did you start QEMU ? Did you forget to use shared memory ?
>
> I had:
>
>        -m 8192 \
>        -object memory-backend-memfd,id=mem,size=8G,share=on \
>
> Alongside:
>
>        -device virtio-gpu-pci \
>        -device qemu-xhci -device usb-kbd \
>        -kernel ~/lsrc/linux.git/builds/arm64/arch/arm64/boot/Image.gz
> -append 'console=ttyAMA0 root=/dev/sda2' \
>        -display gtk,gl=on \
>        -chardev socket,id=mouse2,path=/tmp/mouse.sock -device vhost-user-input-pci,chardev=mouse2
>
> I even double checked with the generic device I was working with:
>
>        -chardev socket,id=mouse2,path=/tmp/mouse.sock -device
> vhost-user-device-pci,chardev=mouse2,virtio-id=18,config_size=136,num_vqs=2

Ahh but not the magic:

  -numa node,memdev=mem

>
>> We should probably add some error at QEMU level when vhost-user devices
>> are used without shared memory!
>
> That would certainly be a good idea.

Where would the best place to do this check be?

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


      reply	other threads:[~2023-10-24 15:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 16:18 State of contrib/vhost-user-input? Alex Bennée
2023-10-23 23:14 ` Stefan Hajnoczi
2023-10-24 11:36 ` Marc-André Lureau
2023-10-24 14:32   ` Alex Bennée
2023-10-24 15:20     ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkco2ghz.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.