All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
	"Fam Zheng" <fam@euphon.net>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	libvir-list@redhat.com, "Fabiano Rosas" <farosas@suse.de>,
	qemu-block@nongnu.org, "Peter Xu" <peterx@redhat.com>,
	"Leonardo Bras" <leobras@redhat.com>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Hailiang Zhang" <zhanghailiang@xfusion.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v4 01/10] migration: Improve json and formatting
Date: Fri, 13 Oct 2023 14:48:53 +0200	[thread overview]
Message-ID: <87bkd2hemi.fsf@pond.sub.org> (raw)
In-Reply-To: <20231013104736.31722-2-quintela@redhat.com> (Juan Quintela's message of "Fri, 13 Oct 2023 12:47:27 +0200")

Juan Quintela <quintela@redhat.com> writes:

> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  qapi/migration.json | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index d7dfaa5db9..6865fea3c5 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -73,7 +73,7 @@
>  { 'struct': 'MigrationStats',
>    'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
>             'duplicate': 'int',
> -           'skipped': { 'type': 'int', 'features': ['deprecated'] },
> +           'skipped': { 'type': 'int', 'features': [ 'deprecated' ] },
>             'normal': 'int',
>             'normal-bytes': 'int', 'dirty-pages-rate': 'int',
>             'mbps': 'number', 'dirty-sync-count': 'int',
> @@ -440,10 +440,9 @@
>  #     compress and xbzrle are both on, compress only takes effect in
>  #     the ram bulk stage, after that, it will be disabled and only
>  #     xbzrle takes effect, this can help to minimize migration
> -#     traffic.  The feature is disabled by default.  (since 2.4 )
> +#     traffic.  The feature is disabled by default.  (since 2.4)
>  #
> -# @events: generate events for each migration state change (since 2.4
> -#     )
> +# @events: generate events for each migration state change (since 2.4)
>  #
>  # @auto-converge: If enabled, QEMU will automatically throttle down
>  #     the guest to speed up convergence of RAM migration.  (since 1.6)

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2023-10-13 12:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 10:47 [PATCH v4 00/10] Migration deprecated parts Juan Quintela
2023-10-13 10:47 ` [PATCH v4 01/10] migration: Improve json and formatting Juan Quintela
2023-10-13 12:48   ` Markus Armbruster [this message]
2023-10-13 10:47 ` [PATCH v4 02/10] migration: Print block status when needed Juan Quintela
2023-10-13 10:47 ` [PATCH v4 03/10] migration: migrate 'inc' command option is deprecated Juan Quintela
2023-10-13 13:09   ` Markus Armbruster
2023-10-16  7:00     ` Juan Quintela
2023-10-16  9:42       ` Markus Armbruster
2023-10-16 13:28         ` Juan Quintela
2023-10-17  5:53           ` Markus Armbruster
2023-10-13 10:47 ` [PATCH v4 04/10] migration: migrate 'blk' " Juan Quintela
2023-10-13 13:11   ` Markus Armbruster
2023-10-13 10:47 ` [PATCH v4 05/10] migration: Deprecate block migration Juan Quintela
2023-10-13 10:47 ` [PATCH v4 06/10] migration: Deprecate old compression method Juan Quintela
2023-10-13 10:47 ` [PATCH v4 07/10] [RFC] migration: Make -i/-b an error for hmp and qmp Juan Quintela
2023-10-13 10:47 ` [PATCH v4 08/10] [RFC] migration: Remove helpers needed for -i/-b migrate options Juan Quintela
2023-10-13 10:47 ` [PATCH v4 09/10] [RFC] migration: Remove support for block_incremental Juan Quintela
2023-10-13 10:47 ` [PATCH v4 10/10] [RFC] migration: Remove block migration support Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkd2hemi.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dave@treblig.org \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=farosas@suse.de \
    --cc=leobras@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=zhanghailiang@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.