Re: [PATCH v2 1/5] drm/format-helper: Add struct drm_xfrm_buf to cache format conversion

[Javier Martinez Canillas <javierm@redhat.com>]

Thomas Zimmermann <tzimmermann@suse.de> writes:

Hello Thomas,

> Hi Javier
>
> Am 29.09.23 um 10:27 schrieb Javier Martinez Canillas:

[...]

>>> +/**
>>> + * struct drm_xfrm_buf - Stores transformation and conversion state
>>> + *
>>> + * DRM helpers for format conversion store temporary state in
>>> + * struct drm_xfrm_buf. The buffer's resources can be reused
>> 
>> And same here. Maybe struct drm_fmt_conversion_buf ?
>
> I find this name to be unpleasant to read. Can we use 
> drm_format_conv_state or drm_fmtcnv_state?
>

Sure, it was just a suggestion. Anything than xfrm_buf works for me :)

From your options I prefer the former, which is easier to understand.

> In the discussion about the panic handler, I mentioned that the struct 
> can be used to store more inforamtion, such as palette entries or fg/bg 
> colors. That would enable support for converting indexed formats, hence 
> the _state postfix.
>

Got it. Makes sense.

> In the longer term, I'd also like to replace the drm_framebuffer from 
> the API and then rename the functions to something like 
> drm_fmtcnv_<x>_to_<y>(). The framebuffer really doesn't make much sense 
> any longer.
>

Agreed.

> Best regards
> Thomas
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat