From: Peter Korsgaard <peter@korsgaard.com>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openblas: fix some x86 32bit builds
Date: Sun, 24 Sep 2023 20:32:49 +0200 [thread overview]
Message-ID: <87bkdrjub2.fsf@48ers.dk> (raw)
In-Reply-To: <20230915193344.1434907-1-ju.o@free.fr> (Julien Olivain's message of "Fri, 15 Sep 2023 21:33:44 +0200")
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> OpenBLAS Makefile normally needs to explicitly define the CPU
> architecture size (32 or 64bit) in the BINARY macro. See [1].
> When an architecture supports both 64 and 32bit, the 32bit support
> is sometimes implemented in OpenBLAS by overriding a fallback to an
> anterior architecture. For example, if the build target architecture
> is x86 Haswell 32bit, OpenBLAS build will override the arch to
> Nehalem. See [2].
> If the BINARY macro is undefined, the 32bit fallback will not happen,
> sometimes leading to a link failure, with output:
> i686-buildroot-linux-gnu/bin/ar: strmm_kernel_LN.o: No such file or directory
> This commit fixes those issues by explicitly defining the BINARY
> macro. This issue has also been discussed upstream in [3] and [4].
> Note: this issue was not introduced recently ([3] dates back from 2015),
> and was also see in previous package version, for example in [5].
> Fixes:
> http://autobuild.buildroot.net/results/e1e/e1e2034a78799abe1bd28b036fa6f7d13322e42f
> [1] https://github.com/xianyi/OpenBLAS/blob/v0.3.24/Makefile.rule#L50
> [2] https://github.com/xianyi/OpenBLAS/blob/v0.3.24/Makefile.system#L113
> [3] https://github.com/xianyi/OpenBLAS/issues/657
> [4] https://github.com/xianyi/OpenBLAS/issues/1106
> [5] http://autobuild.buildroot.net/results/5cd/5cdccd106b1de275ac75c39783e536107a31651f
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-24 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 19:33 [Buildroot] [PATCH 1/1] package/openblas: fix some x86 32bit builds Julien Olivain
2023-09-15 20:51 ` Yann E. MORIN
2023-09-24 18:32 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkdrjub2.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.