From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: Re: [Intel-xe] [PATCH v3 4/5] drm/xe: Add i915_gem.h compatibility header
Date: Thu, 14 Sep 2023 12:45:17 +0300 [thread overview]
Message-ID: <87bke5w0k2.fsf@intel.com> (raw)
In-Reply-To: <20230913095412.3427407-5-jouni.hogander@intel.com>
On Wed, 13 Sep 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> Add i915_gem.h compatibility header and include it in i915_drv.h. Add
> empty GEM_BUG_ON definition for fbc code.
I don't mind merging this as the interim solution so we don't block your
progress, but I think we should just get rid of GEM_BUG_ON/GEM_WARN_ON
in display code:
https://patchwork.freedesktop.org/series/123679/
BR,
Jani.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 +
> drivers/gpu/drm/xe/compat-i915-headers/i915_gem.h | 9 +++++++++
> 2 files changed, 10 insertions(+)
> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_gem.h
>
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> index 6607c5a374cc..55d0d5c7a386 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> @@ -15,6 +15,7 @@
> #include "xe_bo.h"
> #include "xe_pm.h"
> #include "xe_step.h"
> +#include "i915_gem.h"
> #include "i915_gem_stolen.h"
> #include "i915_reg_defs.h"
> #include "i915_utils.h"
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_gem.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem.h
> new file mode 100644
> index 000000000000..06b723a479c5
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +#ifndef __I915_GEM_H__
> +#define __I915_GEM_H__
> +#define GEM_BUG_ON
> +#endif
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-09-14 9:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:54 [Intel-xe] [PATCH v3 0/5] FBC refactoring Jouni Högander
2023-09-13 9:54 ` [Intel-xe] [PATCH v3 1/5] Revert "drm/i915/display: Implement FBC support" Jouni Högander
2023-09-13 9:54 ` [Intel-xe] [PATCH v3 2/5] fixup! drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-09-13 9:54 ` [Intel-xe] [PATCH v3 3/5] drm/xe: Xe stolen memory handling for fbc support Jouni Högander
2023-09-13 9:54 ` [Intel-xe] [PATCH v3 4/5] drm/xe: Add i915_gem.h compatibility header Jouni Högander
2023-09-14 9:45 ` Jani Nikula [this message]
2023-09-13 9:54 ` [Intel-xe] [PATCH v3 5/5] drm/xe: Add Xe implementation for fence checks used by fbc code Jouni Högander
2023-09-13 10:36 ` [Intel-xe] ✓ CI.Patch_applied: success for FBC refactoring (rev4) Patchwork
2023-09-13 10:37 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-13 10:38 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-13 10:45 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-13 10:45 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-13 10:46 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-13 11:19 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-09-13 14:32 ` [Intel-xe] ✓ CI.Patch_applied: success for FBC refactoring (rev5) Patchwork
2023-09-13 14:32 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-13 14:34 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-13 14:41 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-13 14:41 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-13 14:42 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-13 15:13 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bke5w0k2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.