From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Bernie Huang <phhuang@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtw88: fix typo rtw8822cu_probe
Date: Fri, 25 Aug 2023 10:22:34 +0300 [thread overview]
Message-ID: <87bkevh9hh.fsf@kernel.org> (raw)
In-Reply-To: <95d1062787fc4b2994f4b880179f41ef@realtek.com> (Ping-Ke Shih's message of "Fri, 25 Aug 2023 07:02:35 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
>> -----Original Message-----
>> From: Kalle Valo <kvalo@kernel.org>
>> Sent: Friday, August 25, 2023 2:47 PM
>> To: Ping-Ke Shih <pkshih@realtek.com>
>> Cc: Bernie Huang <phhuang@realtek.com>; linux-wireless@vger.kernel.org
>> Subject: Re: [PATCH] wifi: rtw88: fix typo rtw8822cu_probe
>>
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>>
>> > From: Po-Hao Huang <phhuang@realtek.com>
>> >
>> > The probe function of 8822cu is misplaced to 8822bu, so we fix it.
>> >
>> > Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")
>> > Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>>
>> I guess this is just a cosmetic change and does not cause any changes in
>> functionality? I can add that to the commit log.
>
> Yes, it doesn't change anything. If Fixes tag is not suitable, please also
> remove it.
Good point, as this is not fixing any functionality in opinion there
should not be a Fixes tag. I'll also remove that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-08-25 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 6:24 [PATCH] wifi: rtw88: fix typo rtw8822cu_probe Ping-Ke Shih
2023-08-25 6:46 ` Kalle Valo
2023-08-25 7:02 ` Ping-Ke Shih
2023-08-25 7:22 ` Kalle Valo [this message]
2023-09-04 17:31 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkevh9hh.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.