Re: [PATCH 06/17] cmd: sdp: Reorder variable declaration

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

On sam., août 19, 2023 at 16:23, Marek Vasut <marex@denx.de> wrote:

> Move the variable declaration around to improve code readability.
> No functional change.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: Dmitrii Merkurev <dimorinny@google.com>
> Cc: Eddie Cai <eddie.cai.linux@gmail.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Philipp Tomsich <philipp.tomsich@vrull.eu>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stefan Roese <sr@denx.de>
> Cc: kernel@puri.sm
> ---
>  cmd/usb_gadget_sdp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

>
> diff --git a/cmd/usb_gadget_sdp.c b/cmd/usb_gadget_sdp.c
> index 1af82e11366..784d1b49768 100644
> --- a/cmd/usb_gadget_sdp.c
> +++ b/cmd/usb_gadget_sdp.c
> @@ -14,13 +14,13 @@
>  
>  static int do_sdp(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>  {
> +	int controller_index;
>  	int ret;
>  
>  	if (argc < 2)
>  		return CMD_RET_USAGE;
>  
> -	char *usb_controller = argv[1];
> -	int controller_index = simple_strtoul(usb_controller, NULL, 0);
> +	controller_index = simple_strtoul(argv[1], NULL, 0);
>  	usb_gadget_initialize(controller_index);
>  
>  	g_dnl_clear_detach();
> -- 
> 2.40.1