From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, eblake@redhat.com,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH 5/6] qapi: Correct "eg." to "e.g." in documentation
Date: Thu, 20 Jul 2023 17:13:32 +0200 [thread overview]
Message-ID: <87bkg64nvn.fsf@pond.sub.org> (raw)
In-Reply-To: <7e62d4fd-a23d-8dfc-1d3b-dae63975bc53@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Thu, 20 Jul 2023 15:41:21 +0200")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Hi Markus,
>
> On 20/7/23 09:16, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> qapi/char.json | 2 +-
>> qapi/misc.json | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/qapi/char.json b/qapi/char.json
>> index e413ac2b70..52aaff25eb 100644
>> --- a/qapi/char.json
>> +++ b/qapi/char.json
>> @@ -18,7 +18,7 @@
>> # @filename: the filename of the character device
>> #
>> # @frontend-open: shows whether the frontend device attached to this
>> -# backend (eg. with the chardev=... option) is in open or closed
>> +# backend (e.g. with the chardev=... option) is in open or closed
>> # state (since 2.1)
>> #
>> # Notes: @filename is encoded using the QEMU command line character
>> diff --git a/qapi/misc.json b/qapi/misc.json
>> index ff070ec828..cda2effa81 100644
>> --- a/qapi/misc.json
>> +++ b/qapi/misc.json
>> @@ -18,7 +18,7 @@
>> # fail and the FD will be closed.
>> #
>> # @protocol: protocol name. Valid names are "vnc", "spice",
>> -# "@dbus-display" or the name of a character device (eg. from
>> +# "@dbus-display" or the name of a character device (e.g. from
>> # -chardev id=XXXX)
>> #
>> # @fdname: file descriptor name previously passed via 'getfd' command
>
> $ git grep -wF 'eg.' | wc -l
> 45
>
> Why not fix all the tree?
Because I have qapi/ myopia today?
next prev parent reply other threads:[~2023-07-20 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 7:16 [PATCH 0/6] qapi: Tidy up doc comments Markus Armbruster
2023-07-20 7:16 ` [PATCH 1/6] qapi/block-core: Tidy up BlockLatencyHistogramInfo documentation Markus Armbruster
2023-07-20 7:16 ` [PATCH 2/6] qapi/block: Tidy up block-latency-histogram-set documentation Markus Armbruster
2023-07-20 13:39 ` Philippe Mathieu-Daudé
2023-07-20 7:16 ` [PATCH 3/6] qapi/qdev: Tidy up device_add documentation Markus Armbruster
2023-07-20 13:42 ` Philippe Mathieu-Daudé
2023-07-20 7:16 ` [PATCH 4/6] qapi/trace: Tidy up trace-event-get-state, -set-state documentation Markus Armbruster
2023-07-20 7:16 ` [PATCH 5/6] qapi: Correct "eg." to "e.g." in documentation Markus Armbruster
2023-07-20 13:41 ` Philippe Mathieu-Daudé
2023-07-20 15:13 ` Markus Armbruster [this message]
2023-07-20 7:16 ` [PATCH 6/6] qapi: Reformat recent doc comments to conform to current conventions Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkg64nvn.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.