Re: [PATCH 05/24] linux-user: Split TARGET_PROT_* out of syscall_defs.h

["Alex Bennée" <alex.bennee@linaro.org>]

Richard Henderson <richard.henderson@linaro.org> writes:

> Move the values into the per-target target_mman.h headers
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/aarch64/target_mman.h |  3 +++
>  linux-user/generic/target_mman.h |  4 ++++
>  linux-user/mips/target_mman.h    |  2 ++
>  linux-user/syscall_defs.h        | 11 -----------
>  linux-user/xtensa/target_mman.h  |  2 ++
>  5 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/linux-user/aarch64/target_mman.h b/linux-user/aarch64/target_mman.h
> index e7ba6070fe..7f15cab25e 100644
> --- a/linux-user/aarch64/target_mman.h
> +++ b/linux-user/aarch64/target_mman.h
> @@ -1 +1,4 @@
> +#define TARGET_PROT_BTI         0x10
> +#define TARGET_PROT_MTE         0x20
> +
>  #include "../generic/target_mman.h"
> diff --git a/linux-user/generic/target_mman.h b/linux-user/generic/target_mman.h
> index 7b888fb7f8..39a650e751 100644
> --- a/linux-user/generic/target_mman.h
> +++ b/linux-user/generic/target_mman.h
> @@ -1,6 +1,10 @@
>  #ifndef LINUX_USER_TARGET_MMAN_H
>  #define LINUX_USER_TARGET_MMAN_H
>  
> +#ifndef TARGET_PROT_SEM
> +#define TARGET_PROT_SEM                 0x08
> +#endif
> +

I wonder if it is worth adding some commentary at the top that this file
should only be included from the arch specific target_mman.h as there is
an implicit ordering requirement for #ifndef to work properly.

Anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro