All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Matteo Rizzo <matteorizzo@google.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	io-uring@vger.kernel.org, jordyzomer@google.com, evn@google.com,
	poprdi@google.com, corbet@lwn.net, axboe@kernel.dk,
	asml.silence@gmail.com, akpm@linux-foundation.org,
	keescook@chromium.org, rostedt@goodmis.org,
	dave.hansen@linux.intel.com, ribalda@chromium.org,
	chenhuacai@kernel.org, steve@sk2.org, gpiccoli@igalia.com,
	ldufour@linux.ibm.com, bhe@redhat.com, oleksandr@natalenko.name
Subject: Re: [PATCH v2 1/1] Add a new sysctl to disable io_uring system-wide
Date: Thu, 29 Jun 2023 14:36:37 -0400	[thread overview]
Message-ID: <87bkgyt8sq.fsf@suse.de> (raw)
In-Reply-To: <20230629132711.1712536-2-matteorizzo@google.com> (Matteo Rizzo's message of "Thu, 29 Jun 2023 13:27:11 +0000")

Matteo Rizzo <matteorizzo@google.com> writes:

> Introduce a new sysctl (io_uring_disabled) which can be either 0, 1,
> or 2. When 0 (the default), all processes are allowed to create io_uring
> instances, which is the current behavior. When 1, all calls to
> io_uring_setup fail with -EPERM unless the calling process has
> CAP_SYS_ADMIN. When 2, calls to io_uring_setup fail with -EPERM
> regardless of privilege.
>
> Signed-off-by: Matteo Rizzo <matteorizzo@google.com>
> ---

Thanks for adding the extra level for root-only rings.

The patch looks good to me.

Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>

-- 
Gabriel Krisman Bertazi

  parent reply	other threads:[~2023-06-29 18:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 13:27 [PATCH v2 0/1] Add a sysctl to disable io_uring system-wide Matteo Rizzo
2023-06-29 13:27 ` [PATCH v2 1/1] Add a new " Matteo Rizzo
2023-06-29 15:15   ` Bart Van Assche
2023-06-29 15:28     ` Matteo Rizzo
2023-06-29 17:37       ` Bart Van Assche
2023-06-29 16:17   ` Jeff Moyer
2023-06-29 18:36   ` Gabriel Krisman Bertazi [this message]
2023-06-30 15:04     ` Matteo Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkgyt8sq.fsf@suse.de \
    --to=krisman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bhe@redhat.com \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=evn@google.com \
    --cc=gpiccoli@igalia.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jordyzomer@google.com \
    --cc=keescook@chromium.org \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matteorizzo@google.com \
    --cc=oleksandr@natalenko.name \
    --cc=poprdi@google.com \
    --cc=ribalda@chromium.org \
    --cc=rostedt@goodmis.org \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.