From: Peter Korsgaard <peter@korsgaard.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/perl-http-message: add missing reverse dependency on perl-clone
Date: Mon, 05 Jun 2023 11:39:00 +0200 [thread overview]
Message-ID: <87bkhu9rkb.fsf@48ers.dk> (raw)
In-Reply-To: <20230603210642.264930-1-romain.naour@gmail.com> (Romain Naour's message of "Sat, 3 Jun 2023 23:06:42 +0200")
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> Commit [1] added dependency on perl-clone but forgot to propagate
> the reverse dependency on !BR2_STATIC_LIBS.
> Fixes:
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_PERL_CLONE
> Depends on [n]: BR2_PACKAGE_PERL [=y] && !BR2_STATIC_LIBS [=y]
> Selected by [y]:
> - BR2_PACKAGE_PERL_HTTP_MESSAGE [=y] && BR2_PACKAGE_PERL [=y]
> http://autobuild.buildroot.org/results/5d5/5d503aaa94b56523c684be7946123921747ebf52
> [1] 742258fec06df18782e4bd75b00ca530120312cb
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Committed, thanks.
> ---
> While looking at perl-clone build, I noticed that "-shared" is provided
> to lddlflags by the Perl package infrastructure:
> --config lddlflags="-shared $$(TARGET_LDFLAGS)"
> It would means that any Perl package in Buildroot requires a dependency
> on !BR2_STATIC_LIBS.
> Currently some Perl packages doesn't requires !BR2_STATIC_LIBS since they
> simply copy some .pm files. But as soon as something is built, it break
> for static only builds.
Hmm, indeed. Maybe we should just make BR2_PACKAGE_PERL depend on
!BR2_STATIC_LIBS. I doubt there are a lot of use cases for a statically
built perl.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-06-05 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 21:06 [Buildroot] [PATCH] package/perl-http-message: add missing reverse dependency on perl-clone Romain Naour
2023-06-05 9:39 ` Peter Korsgaard [this message]
2023-06-14 13:43 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkhu9rkb.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.