From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Beniamino Galvani <b.galvani@gmail.com>,
Strahinja Jankovic <strahinja.p.jankovic@gmail.com>,
qemu-stable@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH 1/2] hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields
Date: Mon, 24 Apr 2023 18:42:27 +0100 [thread overview]
Message-ID: <87bkjd9nww.fsf@linaro.org> (raw)
In-Reply-To: <20230424165053.1428857-2-peter.maydell@linaro.org>
Peter Maydell <peter.maydell@linaro.org> writes:
> In allwinner_sdhost_process_desc() we just read directly from
> guest memory into a host TransferDescriptor struct and back.
> This only works on little-endian hosts. Abstract the reading
> and writing of descriptors into functions that handle the
> byte-swapping so that TransferDescriptor structs as seen by
> the rest of the code are always in host-order.
I couldn't find any datasheets on the sdhost hardware but the kernel
certainly explicitly sets the endianess of the descriptors so:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-04-24 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 16:50 [PATCH 0/2] arm: allwinner: fix endianness bugs in sdhost and sun8i-emac Peter Maydell
2023-04-24 16:50 ` [PATCH 1/2] hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields Peter Maydell
2023-04-24 17:32 ` Thomas Huth
2023-04-24 17:42 ` Alex Bennée [this message]
2023-04-25 15:46 ` Philippe Mathieu-Daudé
2023-04-24 16:50 ` [PATCH 2/2] hw/net/allwinner-sun8i-emac: " Peter Maydell
2023-04-24 17:36 ` Thomas Huth
2023-04-24 17:44 ` Alex Bennée
2023-04-25 15:45 ` Philippe Mathieu-Daudé
2023-05-02 10:34 ` [PATCH 0/2] arm: allwinner: fix endianness bugs in sdhost and sun8i-emac Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkjd9nww.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=b.galvani@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=strahinja.p.jankovic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.