From: "Alex Bennée" <alex.bennee@linaro.org>
To: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
Cc: bcain@quicinc.com, quic_mathbern@quicinc.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] configure: Fix check-tcg not executing any tests
Date: Fri, 16 Dec 2022 15:04:56 +0000 [thread overview]
Message-ID: <87bko3gzj5.fsf@linaro.org> (raw)
In-Reply-To: <20221207082309.9966-1-quic_mthiyaga@quicinc.com>
Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com> writes:
> After configuring with --target-list=hexagon-linux-user
> running `make check-tcg` just prints the following:
>
> ```
> make: Nothing to be done for 'check-tcg'
> ```
>
> In the probe_target_compiler function, the 'break'
> command is used incorrectly. There are no lexically
> enclosing loops associated with that break command which
> is an unspecfied behaviour in the POSIX standard.
>
> The dash shell implementation aborts the currently executing
> loop, in this case, causing the rest of the logic for the loop
> in line 2490 to be skipped, which means no Makefiles are
> generated for the tcg target tests.
>
> Fixes: c3b570b5a9a24d25 (configure: don't enable
> cross compilers unless in target_list)
>
> Signed-off-by: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
Queued to testing/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2022-12-16 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 8:23 [PATCH] configure: Fix check-tcg not executing any tests Mukilan Thiyagarajan
2022-12-07 9:06 ` Philippe Mathieu-Daudé
2022-12-07 15:51 ` Mukilan Thiyagarajan (QUIC)
2022-12-14 8:15 ` Mukilan Thiyagarajan (QUIC)
2022-12-14 13:30 ` Richard Henderson
2022-12-16 15:04 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bko3gzj5.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bcain@quicinc.com \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=quic_mthiyaga@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.