From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86678C4332F for ; Sun, 27 Nov 2022 23:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mf+qbMTFUGjmqDCnY9H2zFq6n+q6Oa/bIrWjmRzjdRk=; b=PDrOjJKvu+b33a DSfw6JLfrd3VAoG0T7L6YWX0jFB7z8MlZmYxIH2k4TayY8OBgJBufKCYnNas17hR0+Vgxkk04tOd7 4VbANwZgAQCGiKuODBhzm2Y5y/XHu+/7Hzin7xNZRarr1Lwbpaux8wtyyiTydEiBTzzB3/iBY4R6n g5Kbki2C+g+2MUQdH4Gqy/AntJEusYSzB1oHXpXhM/IYMZA9IJjDkQV+CZ337qj30mAoX79nFzn0E w7dsnoU7O77FTgCln4fdFSJiaK1K3TnUVTqBh0/qW5RzdzOQsekRtX4FyASZWShYNBkgfpnGpvoLE 8ve/FoRE9YHhfL6fO2Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozRTb-00EG3x-UU; Sun, 27 Nov 2022 23:54:24 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozRTZ-00EG2Q-53 for linux-arm-kernel@lists.infradead.org; Sun, 27 Nov 2022 23:54:22 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EC411240002; Sun, 27 Nov 2022 23:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669593256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bpe+eTSlDKpTyVgrlJZg4Jsg0Hq3NmOCWl1h1Dm5YQg=; b=ezRXWxJyyKWlsul4Z8h/C56wibHvKTjaGiOLJ7LyaLrl1g4tN0uei2yapJHoQqe6adllxA 3TPsiJREo3aFwAXKGmwcS4rgcbQ0E5VVU4xGmJ3nWeLxW8r1K1lE79oWkhxr6Xzrf1OV6E SaOqu78Hf4wZ7qgCl3zfh5qqV+6Th5gDClLjw7GN2YCyx0LTlO4J2Eeeim9vsFfyfT32KT L+HMhaHLyYSNjCEkmJ5QYAjx/h/Q4jqPzCReu79pELBSS6JYztSvxqmLqL1IELrJolGK1Q 1/4ksRNALbqUsW702ImvEGkaXHZa4wcdI3ScH/tkGVxIACfPYwhsr0T+BZZmHw== From: Gregory CLEMENT To: Andrew Lunn , Pawel Dembicki Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adam Baker , Tony Dinh Subject: Re: [PATCH v2] ARM: dts: kirkwood: Add Zyxel NSA310S board In-Reply-To: References: <20221029205738.4187010-1-paweldembicki@gmail.com> Date: Mon, 28 Nov 2022 00:54:14 +0100 Message-ID: <87bkos9cnt.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221127_155421_366047_BBDCB43A X-CRM114-Status: UNSURE ( 6.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andrew Lunn writes: >> + ethphy0: ethernet-phy@1 { >> + reg = <1>; >> + phy-mode = "rgmii-id"; >> + marvell,reg-init = <0x1 0x16 0x0 0x3>, >> + <0x1 0x10 0x0 0x1017>, >> + <0x1 0x11 0x0 0x4408>, >> + <0x1 0x16 0x0 0x0>; > > The indention is wrong here. > > Otherwise > > Reviewed-by: Andrew Lunn > > Andrew Applied on mvebu/dt I fixed the indentation while applying the patch. Thanks, Gregory -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAAE3C4332F for ; Sun, 27 Nov 2022 23:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbiK0XyT (ORCPT ); Sun, 27 Nov 2022 18:54:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbiK0XyT (ORCPT ); Sun, 27 Nov 2022 18:54:19 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09692BC93 for ; Sun, 27 Nov 2022 15:54:17 -0800 (PST) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EC411240002; Sun, 27 Nov 2022 23:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669593256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bpe+eTSlDKpTyVgrlJZg4Jsg0Hq3NmOCWl1h1Dm5YQg=; b=ezRXWxJyyKWlsul4Z8h/C56wibHvKTjaGiOLJ7LyaLrl1g4tN0uei2yapJHoQqe6adllxA 3TPsiJREo3aFwAXKGmwcS4rgcbQ0E5VVU4xGmJ3nWeLxW8r1K1lE79oWkhxr6Xzrf1OV6E SaOqu78Hf4wZ7qgCl3zfh5qqV+6Th5gDClLjw7GN2YCyx0LTlO4J2Eeeim9vsFfyfT32KT L+HMhaHLyYSNjCEkmJ5QYAjx/h/Q4jqPzCReu79pELBSS6JYztSvxqmLqL1IELrJolGK1Q 1/4ksRNALbqUsW702ImvEGkaXHZa4wcdI3ScH/tkGVxIACfPYwhsr0T+BZZmHw== From: Gregory CLEMENT To: Andrew Lunn , Pawel Dembicki Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adam Baker , Tony Dinh Subject: Re: [PATCH v2] ARM: dts: kirkwood: Add Zyxel NSA310S board In-Reply-To: References: <20221029205738.4187010-1-paweldembicki@gmail.com> Date: Mon, 28 Nov 2022 00:54:14 +0100 Message-ID: <87bkos9cnt.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Andrew Lunn writes: >> + ethphy0: ethernet-phy@1 { >> + reg = <1>; >> + phy-mode = "rgmii-id"; >> + marvell,reg-init = <0x1 0x16 0x0 0x3>, >> + <0x1 0x10 0x0 0x1017>, >> + <0x1 0x11 0x0 0x4408>, >> + <0x1 0x16 0x0 0x0>; > > The indention is wrong here. > > Otherwise > > Reviewed-by: Andrew Lunn > > Andrew Applied on mvebu/dt I fixed the indentation while applying the patch. Thanks, Gregory -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com