From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Zhenyu Zhang <zhenyzha@redhat.com>,
qemu-devel@nongnu.org, shan.gavin@gmail.com,
liuyd.fnst@fujitsu.com, eric.auger@redhat.com,
Igor Mammedov <imammedo@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] qom.json: default the prealloc-threads to smp-cpus
Date: Fri, 04 Nov 2022 05:53:02 +0100 [thread overview]
Message-ID: <87bkpn2udt.fsf@pond.sub.org> (raw)
In-Reply-To: <7eecb87f-7d37-93d0-db93-21f7c6374d91@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Thu, 3 Nov 2022 12:00:15 +0100")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 3/11/22 11:47, Zhenyu Zhang wrote:
>> Since the amount of prealloc-threads to smp-cpus is
>> defaulted in hostmem, so sync this information.
Has this always defaulted to smp-cpus, or did this change along the way?
>> Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
>> ---
>> qapi/qom.json | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/qapi/qom.json b/qapi/qom.json
>> index 87fcad2423..ac4cd213a7 100644
>> --- a/qapi/qom.json
>> +++ b/qapi/qom.json
>> @@ -576,7 +576,7 @@
>> #
>> # @prealloc: if true, preallocate memory (default: false)
>> #
>> -# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
>> +# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)
>
> The property is present since 5.0. Shouldn't this be "(default: smp-cpus) (since 5.0)"?
Yes.
>> #
>> # @prealloc-context: thread context to use for creation of preallocation threads
>> # (default: none) (since 7.2)
next prev parent reply other threads:[~2022-11-04 4:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 10:47 [PATCH] qom.json: default the prealloc-threads to smp-cpus Zhenyu Zhang
2022-11-03 11:00 ` Philippe Mathieu-Daudé
2022-11-04 1:57 ` Zhenyu Zhang
2022-11-04 9:29 ` Philippe Mathieu-Daudé
2022-11-04 9:44 ` Zhenyu Zhang
2022-11-04 4:53 ` Markus Armbruster [this message]
2022-11-04 13:21 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkpn2udt.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=liuyd.fnst@fujitsu.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shan.gavin@gmail.com \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.