From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 031EAC4332F for ; Mon, 17 Oct 2022 20:13:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D813210EE09; Mon, 17 Oct 2022 20:13:01 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9C6D10E9ED; Mon, 17 Oct 2022 20:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666037569; x=1697573569; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=PDVhYAC19v8x5R10vT8eqWGRWFUXoSsBW6rCMezvNbI=; b=Wd1Xfe1jRNzFqLjAlbgs5MQxjgtnG7477IkizyUFOexinE5FJCiQJdZ5 6NzDuiNH8LSO623XBiYICI/76uOLVrsw5aF4QIFEDoNVhRjltCnn3nBif IiQpQufmy30EfVt7dIBlsGdMIXRyxgk93WQaTeXY+dwNgQxAJhnqp7csG CQL7C4uKIykKUknW53/vfhwGXHsDP5xgg1WeA75ItuiH9pEwUhpkfoqnQ Z3PxlRChggfaxTwD73ejAlRRPhpqEyMtlfmihZlk4Hh3BZaAq4wbwb9No ZUkBzerElqPLyTmpq6FmBcR8YM5KAcifYRrLDhxtAnFexJM5EyMTyvDfe g==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="370108060" X-IronPort-AV: E=Sophos;i="5.95,192,1661842800"; d="scan'208";a="370108060" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 13:12:48 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="717624177" X-IronPort-AV: E=Sophos;i="5.95,192,1661842800"; d="scan'208";a="717624177" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.255.229.228]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 13:12:48 -0700 Date: Mon, 17 Oct 2022 13:12:33 -0700 Message-ID: <87bkqajjke.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-gfx@lists.freedesktop.org In-Reply-To: <20221015032618.2458429-4-ashutosh.dixit@intel.com> References: <20221015032618.2458429-1-ashutosh.dixit@intel.com> <20221015032618.2458429-4-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/mtl: C6 residency and C state type for MTL SAMedia X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 14 Oct 2022 20:26:18 -0700, Ashutosh Dixit wrote: > > From: Badal Nilawar Hi Badal, One question below. > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > index 1fb053cbf52db..3a9bb4387248e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > @@ -256,6 +256,61 @@ static int ilk_drpc(struct seq_file *m) > return 0; > } > > +static int mtl_drpc(struct seq_file *m) > +{ Here we have: > + global_forcewake = intel_uncore_read(uncore, FORCEWAKE_GT_GEN9); and > + seq_printf(m, "Global Forcewake Requests: 0x%x\n", global_forcewake); In gen6_drpc we have: mt_fwake_req = intel_uncore_read_fw(uncore, FORCEWAKE_MT); and seq_printf(m, "Multi-threaded Forcewake Request: 0x%x\n", mt_fwake_req); Also: #define FORCEWAKE_MT _MMIO(0xa188) #define FORCEWAKE_GT_GEN9 _MMIO(0xa188) So they are both the same register. So what is the reason for this difference, which one should we use? Also let's have the prints in the same order as gen6_drpc (move fw request before rc6 residency). Thanks. -- Ashutosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53CD1C4332F for ; Mon, 17 Oct 2022 20:13:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EABB310E9ED; Mon, 17 Oct 2022 20:12:59 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9C6D10E9ED; Mon, 17 Oct 2022 20:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666037569; x=1697573569; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=PDVhYAC19v8x5R10vT8eqWGRWFUXoSsBW6rCMezvNbI=; b=Wd1Xfe1jRNzFqLjAlbgs5MQxjgtnG7477IkizyUFOexinE5FJCiQJdZ5 6NzDuiNH8LSO623XBiYICI/76uOLVrsw5aF4QIFEDoNVhRjltCnn3nBif IiQpQufmy30EfVt7dIBlsGdMIXRyxgk93WQaTeXY+dwNgQxAJhnqp7csG CQL7C4uKIykKUknW53/vfhwGXHsDP5xgg1WeA75ItuiH9pEwUhpkfoqnQ Z3PxlRChggfaxTwD73ejAlRRPhpqEyMtlfmihZlk4Hh3BZaAq4wbwb9No ZUkBzerElqPLyTmpq6FmBcR8YM5KAcifYRrLDhxtAnFexJM5EyMTyvDfe g==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="370108060" X-IronPort-AV: E=Sophos;i="5.95,192,1661842800"; d="scan'208";a="370108060" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 13:12:48 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="717624177" X-IronPort-AV: E=Sophos;i="5.95,192,1661842800"; d="scan'208";a="717624177" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.255.229.228]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 13:12:48 -0700 Date: Mon, 17 Oct 2022 13:12:33 -0700 Message-ID: <87bkqajjke.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm/i915/mtl: C6 residency and C state type for MTL SAMedia In-Reply-To: <20221015032618.2458429-4-ashutosh.dixit@intel.com> References: <20221015032618.2458429-1-ashutosh.dixit@intel.com> <20221015032618.2458429-4-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Badal Nilawar Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 14 Oct 2022 20:26:18 -0700, Ashutosh Dixit wrote: > > From: Badal Nilawar Hi Badal, One question below. > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > index 1fb053cbf52db..3a9bb4387248e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > @@ -256,6 +256,61 @@ static int ilk_drpc(struct seq_file *m) > return 0; > } > > +static int mtl_drpc(struct seq_file *m) > +{ Here we have: > + global_forcewake = intel_uncore_read(uncore, FORCEWAKE_GT_GEN9); and > + seq_printf(m, "Global Forcewake Requests: 0x%x\n", global_forcewake); In gen6_drpc we have: mt_fwake_req = intel_uncore_read_fw(uncore, FORCEWAKE_MT); and seq_printf(m, "Multi-threaded Forcewake Request: 0x%x\n", mt_fwake_req); Also: #define FORCEWAKE_MT _MMIO(0xa188) #define FORCEWAKE_GT_GEN9 _MMIO(0xa188) So they are both the same register. So what is the reason for this difference, which one should we use? Also let's have the prints in the same order as gen6_drpc (move fw request before rc6 residency). Thanks. -- Ashutosh