From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7141ECAAD3 for ; Thu, 1 Sep 2022 12:39:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 73DB31621; Thu, 1 Sep 2022 14:38:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 73DB31621 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1662035961; bh=qSNLsy30GaYKSMMqZ+mxB+r29IqqJ+Y4v8uczFXFX/I=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PmJvzmGWfc4zqmw5Ol2MumNm7rmuQvQfPSh+JJ1JXxewHp+jBc3APfkt9haQaLjxg WXJNIoXsJmMEGQfKD3CMS8b0Qgl4mPbda9mzIBkHAGB/uvr1ZwH3xa+tzB6coK2GKA uOBpaclQZUQRM9TJzExxDPTdU6z7LhCfbGMOacvI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E7B11F8026A; Thu, 1 Sep 2022 14:38:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 43207F8026D; Thu, 1 Sep 2022 14:38:28 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1A6C2F80163 for ; Thu, 1 Sep 2022 14:38:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1A6C2F80163 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="oH7YCTbk"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="EyAY5ANe" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B3EC1FE17; Thu, 1 Sep 2022 12:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662035901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5aHnvpxKXtvoC+dCkAemXBA0d+yOcIeXMa3oaNXoEmg=; b=oH7YCTbkpGjK8ry3y9onrFcDubGO17vu3B7h7eed/UtPfvVwdnlWVvqUrfIxKPJOhTsOAp qvx9k0vR6hmRZJHOuzLtWGFSI5LPgcHo26/BQj1URP8UArFm8X2HIUWttuaF6AXVNBAMAP jVwnlbSfU8OgarTsOl61r80bvcISEa8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662035901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5aHnvpxKXtvoC+dCkAemXBA0d+yOcIeXMa3oaNXoEmg=; b=EyAY5ANeE3+s4oPiSwjmWdk6+/a48ByCklRfzPje3yGAm5bsS3rQr5MWcAlgFEb3xfJ9HW hhrVKU4GacR4OKDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 13FBE13A89; Thu, 1 Sep 2022 12:38:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /MUqBL2nEGM1KQAAMHmgww (envelope-from ); Thu, 01 Sep 2022 12:38:21 +0000 Date: Thu, 01 Sep 2022 14:38:20 +0200 Message-ID: <87bkrzxoar.wl-tiwai@suse.de> From: Takashi Iwai To: Valentina Goncharenko Subject: Re: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak() In-Reply-To: <20220901102814.131855-1-goncharenko.vp@ispras.ru> References: <20220901102814.131855-1-goncharenko.vp@ispras.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: ldv-project@linuxtesting.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Eliot Blennerhassett X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 01 Sep 2022 12:28:14 +0200, Valentina Goncharenko wrote: > > The hpi_meter_get_peak() function contains the expression > "hm.obj_index = hm.obj_index", which does not carry any semantic load. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards") > Signed-off-by: Valentina Goncharenko Thanks, applied. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 982A3ECAAD3 for ; Thu, 1 Sep 2022 12:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbiIAMia (ORCPT ); Thu, 1 Sep 2022 08:38:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbiIAMi2 (ORCPT ); Thu, 1 Sep 2022 08:38:28 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94866DF2 for ; Thu, 1 Sep 2022 05:38:22 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B3EC1FE17; Thu, 1 Sep 2022 12:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662035901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5aHnvpxKXtvoC+dCkAemXBA0d+yOcIeXMa3oaNXoEmg=; b=oH7YCTbkpGjK8ry3y9onrFcDubGO17vu3B7h7eed/UtPfvVwdnlWVvqUrfIxKPJOhTsOAp qvx9k0vR6hmRZJHOuzLtWGFSI5LPgcHo26/BQj1URP8UArFm8X2HIUWttuaF6AXVNBAMAP jVwnlbSfU8OgarTsOl61r80bvcISEa8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662035901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5aHnvpxKXtvoC+dCkAemXBA0d+yOcIeXMa3oaNXoEmg=; b=EyAY5ANeE3+s4oPiSwjmWdk6+/a48ByCklRfzPje3yGAm5bsS3rQr5MWcAlgFEb3xfJ9HW hhrVKU4GacR4OKDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 13FBE13A89; Thu, 1 Sep 2022 12:38:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /MUqBL2nEGM1KQAAMHmgww (envelope-from ); Thu, 01 Sep 2022 12:38:21 +0000 Date: Thu, 01 Sep 2022 14:38:20 +0200 Message-ID: <87bkrzxoar.wl-tiwai@suse.de> From: Takashi Iwai To: Valentina Goncharenko Cc: Jaroslav Kysela , Takashi Iwai , Eliot Blennerhassett , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak() In-Reply-To: <20220901102814.131855-1-goncharenko.vp@ispras.ru> References: <20220901102814.131855-1-goncharenko.vp@ispras.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Sep 2022 12:28:14 +0200, Valentina Goncharenko wrote: > > The hpi_meter_get_peak() function contains the expression > "hm.obj_index = hm.obj_index", which does not carry any semantic load. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards") > Signed-off-by: Valentina Goncharenko Thanks, applied. Takashi