From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F314C00140 for ; Mon, 8 Aug 2022 11:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237547AbiHHLQd (ORCPT ); Mon, 8 Aug 2022 07:16:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231142AbiHHLQb (ORCPT ); Mon, 8 Aug 2022 07:16:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 058C1DF2A for ; Mon, 8 Aug 2022 04:16:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 666996113C for ; Mon, 8 Aug 2022 11:16:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9F34C433C1; Mon, 8 Aug 2022 11:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659957388; bh=vKDn3GWmkKu9N+Wul1D5RdteDfPxM2sCmCWBfALBO+E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JeWZGdVTMV7w4ru03NAonSPxtedMWljR6QeWLJIHBzQKicKd4w5ao996bbzOqqDvX PNLIvNAAOvFt6q2DRwFiaazol+ohBsbTr1i5KEQ8Td8FQCs4ye/D5PNaPU8ZqeCTH7 8Kwm2MmuF8FV8V5UB8sekAQXUzUA41DN0sXPD9Nu5sgsy/Pw1VpT0iwsrBsNe2vrh4 Ki0Vfu9wg+iyJWI9MdlIEBRxIjSV1t+wV5Ht1Uor5tPSV86zUR4+64xuaPIZze6ShS e9q6XSpI2mGYwGIZDtfa04XCWrsrFAZ59r1hcSWZGlANKOs7DWn0z2Or3RM5YoZOwS BtnnicPCyrzoA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oL0kE-001eEB-F9; Mon, 08 Aug 2022 12:16:26 +0100 Date: Mon, 08 Aug 2022 12:16:26 +0100 Message-ID: <87bksvvvcl.wl-maz@kernel.org> From: Marc Zyngier To: Huacai Chen Cc: Huacai Chen , Thomas Gleixner , LKML , Xuefeng Li , Jiaxun Yang , kernel test robot Subject: Re: [PATCH] irqchip: Select downstream irqchip drivers for LoongArch CPU In-Reply-To: References: <20220808085319.3350111-1-chenhuacai@loongson.cn> <87edxrvymh.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: chenhuacai@gmail.com, chenhuacai@loongson.cn, tglx@linutronix.de, linux-kernel@vger.kernel.org, lixuefeng@loongson.cn, jiaxun.yang@flygoat.com, lkp@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08 Aug 2022 12:06:23 +0100, Huacai Chen wrote: > > Hi, Marc, > > On Mon, Aug 8, 2022 at 6:05 PM Marc Zyngier wrote: > > > > On Mon, 08 Aug 2022 09:53:19 +0100, > > Huacai Chen wrote: > > > > > > LoongArch irqchips have a fixed hierarchy which currently can't be > > > described by ACPI tables, so upstream irqchip drivers call downstream > > > irqchip drivers' initialization directly. As a result, the top level > > > (CPU-level) irqchip driver should explicitly select downstream drivers > > > to avoid build errors. > > > > > > Reported-by: kernel test robot > > > Signed-off-by: Huacai Chen > > > --- > > > drivers/irqchip/Kconfig | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > > > index 66b9fa408bf2..2549daa859d6 100644 > > > --- a/drivers/irqchip/Kconfig > > > +++ b/drivers/irqchip/Kconfig > > > @@ -561,6 +561,11 @@ config IRQ_LOONGARCH_CPU > > > select GENERIC_IRQ_CHIP > > > select IRQ_DOMAIN > > > select GENERIC_IRQ_EFFECTIVE_AFF_MASK > > > + select LOONGSON_LIOINTC > > > + select LOONGSON_EIOINTC > > > + select LOONGSON_PCH_PIC > > > + select LOONGSON_PCH_MSI > > > + select LOONGSON_PCH_LPC > > > > This triggers tons of pretty bad compilation and configuration issues, > > as PCI still isn't selectable, even in Linus' tree (see below). I'm > > guessing you still have local patches that hide this issue. > > > > Please test your patches on an upstream tree in the future. > I'm very sorry for that. I think this patch should be delayed after > 5.20-rc1, then PCI code will have been merged. Sure, I'm fine with that. However, I have seen the PCI pull request going in without any mention of the LoongArch support. Is it going via another tree? Thanks, M. -- Without deviation from the norm, progress is not possible.