Re: [PATCH 6/6] rtw89: support MULTI_BSSID and correct BSSID mask of H2C

[Kalle Valo <kvalo@kernel.org>]

Ping-Ke Shih <pkshih@realtek.com> writes:

> The BSSID mask of H2C is used to match BSSID of receiving packets.
> Normally, we set six bits BSSID mask to exactly match BSSID of packets
> sent by target AP. After we support multiple BSSID, it could connect a
> nontransmitted BSSID, so we can only match first five bytes of BSSID.
> That means we could possibly receive other AP's packets if only the last
> byte of BSSID is different from target AP.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
>  drivers/net/wireless/realtek/rtw89/cam.c  | 9 +++++++++
>  drivers/net/wireless/realtek/rtw89/cam.h  | 5 +++++
>  drivers/net/wireless/realtek/rtw89/core.c | 1 +
>  3 files changed, 15 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/cam.c b/drivers/net/wireless/realtek/rtw89/cam.c
> index 8a26adeb23fb2..b211ed2ea0722 100644
> --- a/drivers/net/wireless/realtek/rtw89/cam.c
> +++ b/drivers/net/wireless/realtek/rtw89/cam.c
> @@ -599,14 +599,23 @@ int rtw89_cam_init(struct rtw89_dev *rtwdev, struct rtw89_vif *rtwvif)
>  int rtw89_cam_fill_bssid_cam_info(struct rtw89_dev *rtwdev,
>  				  struct rtw89_vif *rtwvif, u8 *cmd)
>  {
> +#define BSSID_MATCH_ALL GENMASK(5, 0)
> +#define BSSID_MATCH_5_BYTES GENMASK(4, 0)

Please define these elsewhere, like in the beginning of the file or
something. And please add RTW89_ prefix.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches