From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45A9BC433F5 for ; Wed, 18 May 2022 05:01:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B509F1DD; Wed, 18 May 2022 07:00:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B509F1DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652850091; bh=gT+NhQx77NAOLeRCRqz6IqGIuWrrbpEwAqJ/CGWH2CY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NFPaqHqGaKv6djjt7hWF0PsMUl+1jvYYS34BAI/+HEDv33VnFTPTPKZdP//rNeFYW eOxx8boZGzGrUHWevm7ORZY02ojym2foRJno54NAevqhQ798WgHw+J44+r45Hm3fDb a4GmQ02Jogl5Wfpp6+t/bomxVtZptVJe6gq4j8H0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 447B4F800F0; Wed, 18 May 2022 07:00:41 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4DED3F8023B; Wed, 18 May 2022 07:00:38 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 253FCF800F0 for ; Wed, 18 May 2022 07:00:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 253FCF800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tqf0LLx5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="V1PgXNYF" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id AD8ED1F390; Wed, 18 May 2022 05:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652850031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I9YQWhyZX2/RpbjnCcry7qzZl2Hzq5L+6NYKhVenpOM=; b=tqf0LLx5wQK9vqcmxoaxerYLMhj5VOkEtOAWfKlL7aeZCqheNaatorbiNveZZSJb6tLP8V +NzpwND0AgVwO1fr12HQ3FYoOwMfYQ+aExQX/d56QBmJ4s6XwurboazZ6RVcXKTH7QqKPd 0Qudsk0zWVfXI5uZRioqVKFwTvrG1I8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652850031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I9YQWhyZX2/RpbjnCcry7qzZl2Hzq5L+6NYKhVenpOM=; b=V1PgXNYF12XwKN/EeBAaaHHFvcnxWqxE1a1YFKTu3WbmgQdoY7ObkVrhw1yhBoeiaih/7U aU8gUN14KoKseyBQ== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 4E0962C141; Wed, 18 May 2022 05:00:31 +0000 (UTC) Date: Wed, 18 May 2022 07:00:28 +0200 Message-ID: <87bkvvv3ir.wl-tiwai@suse.de> From: Takashi Iwai To: Wan Jiabing Subject: Re: [PATCH] ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all In-Reply-To: <20220518021617.10114-1-wanjiabing@vivo.com> References: <20220518021617.10114-1-wanjiabing@vivo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , gushengxian X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 18 May 2022 04:16:16 +0200, Wan Jiabing wrote: > > Fix following coccicheck error: > ./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671. > > Here should be 'cp' rather than 'ip'. > > Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock") > Signed-off-by: Wan Jiabing Oh, that was a silly failure. Applied now, thanks! Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B12C433F5 for ; Wed, 18 May 2022 05:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbiERFAu (ORCPT ); Wed, 18 May 2022 01:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbiERFAh (ORCPT ); Wed, 18 May 2022 01:00:37 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE7A4BE2F for ; Tue, 17 May 2022 22:00:33 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id AD8ED1F390; Wed, 18 May 2022 05:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652850031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I9YQWhyZX2/RpbjnCcry7qzZl2Hzq5L+6NYKhVenpOM=; b=tqf0LLx5wQK9vqcmxoaxerYLMhj5VOkEtOAWfKlL7aeZCqheNaatorbiNveZZSJb6tLP8V +NzpwND0AgVwO1fr12HQ3FYoOwMfYQ+aExQX/d56QBmJ4s6XwurboazZ6RVcXKTH7QqKPd 0Qudsk0zWVfXI5uZRioqVKFwTvrG1I8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652850031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I9YQWhyZX2/RpbjnCcry7qzZl2Hzq5L+6NYKhVenpOM=; b=V1PgXNYF12XwKN/EeBAaaHHFvcnxWqxE1a1YFKTu3WbmgQdoY7ObkVrhw1yhBoeiaih/7U aU8gUN14KoKseyBQ== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 4E0962C141; Wed, 18 May 2022 05:00:31 +0000 (UTC) Date: Wed, 18 May 2022 07:00:28 +0200 Message-ID: <87bkvvv3ir.wl-tiwai@suse.de> From: Takashi Iwai To: Wan Jiabing Cc: Jaroslav Kysela , Takashi Iwai , gushengxian , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all In-Reply-To: <20220518021617.10114-1-wanjiabing@vivo.com> References: <20220518021617.10114-1-wanjiabing@vivo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 May 2022 04:16:16 +0200, Wan Jiabing wrote: > > Fix following coccicheck error: > ./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671. > > Here should be 'cp' rather than 'ip'. > > Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock") > Signed-off-by: Wan Jiabing Oh, that was a silly failure. Applied now, thanks! Takashi