From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8567BC433EF for ; Tue, 17 May 2022 07:51:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF383112EB3; Tue, 17 May 2022 07:51:20 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id E45EC112EB3 for ; Tue, 17 May 2022 07:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652773879; x=1684309879; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=LWIEB4/lPMy65N4AJNM7XhWmKfMhu8OaBtUPWfYPFRM=; b=a8znuvY6f31m/e3Ax0pAMkfSukD9wnSi0NtUlNEdxT90bCcSed4YD77g wl6dtTJ6jWdAJDnswVoyJ8Ablrinpf9+7SWH5Lucizphd3NZcAgQUW2ib YkdXUo54TgPg9JJmzQp6HcK7EGkor3MnAAnRWGFiYhdqKJaNKwalh+PPV bmKnCoidcE510LAaygubm96Ci1eJU6mI9leI0BqyOZ3Yo47j236KvYbF/ UNCIdcZFOPH2sjVim2u7kw9lpWb7FBe/5sl1XTa+7PA3lrrCzHblcYHM9 p6CJM0cuKDpIrQjIeoG3olIeQNiemksEmqIogIEK+QCf1P+ar9GJlwXgB g==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="270794004" X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="270794004" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 00:51:19 -0700 X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="568758921" Received: from psagan-mobl.ger.corp.intel.com (HELO localhost) ([10.249.132.13]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 00:51:16 -0700 From: Jani Nikula To: Mark Yacoub Subject: Re: [PATCH] drm: Add a debug message when getting a prop is missing In-Reply-To: <20220510182810.1223574-1-markyacoub@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220510182810.1223574-1-markyacoub@chromium.org> Date: Tue, 17 May 2022 10:51:14 +0300 Message-ID: <87bkvwfvgt.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , markyacoub@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, Thomas Zimmermann , markyacoub@google.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 10 May 2022, Mark Yacoub wrote: > [Why] > If a connector property is attached but > drm_atomic_connector_get_property doesn't handle a case for it, > modeteset will crash with a segfault without. > > [How] > Add a debug message indicating that a connector property is not handled > when user space is trying to read it. > > TEST=modetest > > Signed-off-by: Mark Yacoub > --- > drivers/gpu/drm/drm_atomic_uapi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c > index acb1ee93d206..36b0f664dd80 100644 > --- a/drivers/gpu/drm/drm_atomic_uapi.c > +++ b/drivers/gpu/drm/drm_atomic_uapi.c > @@ -884,6 +884,12 @@ drm_atomic_connector_get_property(struct drm_connector *connector, > return connector->funcs->atomic_get_property(connector, > state, property, val); > } else { > + // LOG that the kernel is missing handling this property as a case here. The comment is unnecessary, and we also don't use // comments. > + drm_dbg_atomic( > + dev, > + "[CONNECTOR:%d:%s] Get Property [PROP:%d:%s] is not handled\n", > + connector->base.id, connector->name, property->base.id, > + property->name); Why not use the same message as in drm_atomic_connector_set_property()? Blank line here. BR, Jani. > return -EINVAL; > } -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C92B5C433EF for ; Tue, 17 May 2022 07:51:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241639AbiEQHv2 (ORCPT ); Tue, 17 May 2022 03:51:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242175AbiEQHvW (ORCPT ); Tue, 17 May 2022 03:51:22 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E22618382 for ; Tue, 17 May 2022 00:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652773881; x=1684309881; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=LWIEB4/lPMy65N4AJNM7XhWmKfMhu8OaBtUPWfYPFRM=; b=oBQvk/8x+ysG+UXf+EL7cwQUiVXMrkP+DXGzRx6WpNvsb63Irvb8PcE6 zgpf0HFN3P2ppYmVflZAA+1eLxMFpdMSVVx3qP+tIQ7UMr5pejI1Xow4Q vy8HB0kuKzGRAuHMisl5PR5mtRCBjYxslIT6q9XYyoFN29tzM7m/jkfis TDWo1WuKmRKPEXt0PNtjlsu8M9n7TQvz+06ZcV4O+Qj/BpWrpdVjtxknL kucm0DWy4qQOiBXmDJAHf6htGFSX+UqycSPhOMjuifmib4Jpx58kxQDYO +eO6UWBns30tzhXrGYgNefDZ44bYunFkDqhYStHztIRylSayxJQmM6tSZ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="271045377" X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="271045377" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 00:51:19 -0700 X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="568758921" Received: from psagan-mobl.ger.corp.intel.com (HELO localhost) ([10.249.132.13]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 00:51:16 -0700 From: Jani Nikula To: Mark Yacoub Cc: David Airlie , markyacoub@chromium.org, linux-kernel@vger.kernel.org, seanpaul@chromium.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , markyacoub@google.com Subject: Re: [PATCH] drm: Add a debug message when getting a prop is missing In-Reply-To: <20220510182810.1223574-1-markyacoub@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220510182810.1223574-1-markyacoub@chromium.org> Date: Tue, 17 May 2022 10:51:14 +0300 Message-ID: <87bkvwfvgt.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 May 2022, Mark Yacoub wrote: > [Why] > If a connector property is attached but > drm_atomic_connector_get_property doesn't handle a case for it, > modeteset will crash with a segfault without. > > [How] > Add a debug message indicating that a connector property is not handled > when user space is trying to read it. > > TEST=modetest > > Signed-off-by: Mark Yacoub > --- > drivers/gpu/drm/drm_atomic_uapi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c > index acb1ee93d206..36b0f664dd80 100644 > --- a/drivers/gpu/drm/drm_atomic_uapi.c > +++ b/drivers/gpu/drm/drm_atomic_uapi.c > @@ -884,6 +884,12 @@ drm_atomic_connector_get_property(struct drm_connector *connector, > return connector->funcs->atomic_get_property(connector, > state, property, val); > } else { > + // LOG that the kernel is missing handling this property as a case here. The comment is unnecessary, and we also don't use // comments. > + drm_dbg_atomic( > + dev, > + "[CONNECTOR:%d:%s] Get Property [PROP:%d:%s] is not handled\n", > + connector->base.id, connector->name, property->base.id, > + property->name); Why not use the same message as in drm_atomic_connector_set_property()? Blank line here. BR, Jani. > return -EINVAL; > } -- Jani Nikula, Intel Open Source Graphics Center