From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AA2C433EF for ; Mon, 28 Mar 2022 12:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239077AbiC1MdQ (ORCPT ); Mon, 28 Mar 2022 08:33:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242545AbiC1MdF (ORCPT ); Mon, 28 Mar 2022 08:33:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13BD135AA1; Mon, 28 Mar 2022 05:31:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC688B80DFE; Mon, 28 Mar 2022 12:31:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A869FC340EC; Mon, 28 Mar 2022 12:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648470682; bh=fLGdb7dSfAqcoc7SmA0DtwuG5S8J1UMKX6NM0JYvlbE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=vR3sm0Sym9PNeV1iKQGwMQbPO6yRDwohIBCSBdBAAXuDDO0SWpja6OgX6EnOvgTmq TjnzAmmgRqAI7VMMqH2O7CUJ6XEWGQoPVF1AN2lYHSalQOuTT+xH3TeXiapzkBoDDY tTzTYQ5GBWa2GALcTzd9hSykzmqjjHuEIfoQNXYeYukvQqZVWjJgo1IrRVnWgagObl g/dwjiafO/fytUgqLw8IWTrjQWjo/zqFAaNAJAQ8gjKtytzwyaZGjuidRKQhih/yde bDhRRLmxOXxLsSy40enpsfgnUm8nwGiwmrDs+aoLJB2mBmG7Pk8oHcDE3szRC3iHWp ESPsCuNOlpy8A== From: Kalle Valo To: Benjamin =?utf-8?Q?St=C3=BCrz?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 00/22] Replace comments with C99 initializers References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> Date: Mon, 28 Mar 2022 15:31:14 +0300 In-Reply-To: ("Benjamin \=\?utf-8\?Q\?St\=C3\=BCrz\=22's\?\= message of "Mon, 28 Mar 2022 13:51:42 +0200") Message-ID: <87bkxqz2b1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Benjamin St=C3=BCrz writes: > On 28.03.22 11:33, Kalle Valo wrote: >> Benjamin St=C3=BCrz writes: >>=20 >>> This patch series replaces comments with C99's designated initializers >>> in a few places. It also adds some enum initializers. This is my first >>> time contributing to the Linux kernel, therefore I'm probably doing a >>> lot of things the wrong way. I'm sorry for that. >>=20 >> Just a small tip: If you are new, start with something small and learn >> from that. Don't do a controversial big patchset spanning multiple >> subsystems, that's the hard way to learn things. First submit one patch >> at a time to one subsystem and gain understanding of the process that >> way. > > I actually thought this would be such simple thing. If there are 22 patches and a dozen different subsystems it's far from simple, as you noticed from your replies :) > Do you know of any good thing where to start? I already looked into > drivers/staging/*/TODO and didn't found something for me personally. I work in wireless and one my annoyance is use of BUG_ON() in wireless drivers. There just isn't a good reason to crash the whole system when there's a bug in a wireless driver or firmware. You can get list like this: git grep BUG_ON drivers/net/wireless/ | grep -v BUILD_BUG_ON It might not be always trivial to fix BUG_ON() usage, so it would be a good challenge as well. See the wiki link below how to submit wireless patches. But just send a one patch first, don't work for several hours and then submit a big set of patches. We also might have a todo list somewhere in the wiki, but don't know how to up-to-date it is. > Should I drop this patchset and start with something different?=20 Like Mauro suggested, splitting the patchset per subsystem is a very good idea. And first try out with one subsystem, and after seeing how it goes (if they are accepted or rejected), decide if you send more patches to other subsystems. > If yes, what would the proper way to drop it? Just announcing, that > this is going nowhere in a separate patch? Replying to Mauro's email and telling your intentions is a good way to inform everyone. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Mon, 28 Mar 2022 12:31:14 +0000 Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-Id: <87bkxqz2b1.fsf@kernel.org> List-Id: References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> In-Reply-To: ("Benjamin \=\?utf-8\?Q\?St\=C3\=BCrz\=22's\?\= message of "Mon, 28 Mar 2022 13:51:42 +0200") MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Benjamin =?utf-8?Q?St=C3=BCrz?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Benjamin Stürz writes: > On 28.03.22 11:33, Kalle Valo wrote: >> Benjamin Stürz writes: >> >>> This patch series replaces comments with C99's designated initializers >>> in a few places. It also adds some enum initializers. This is my first >>> time contributing to the Linux kernel, therefore I'm probably doing a >>> lot of things the wrong way. I'm sorry for that. >> >> Just a small tip: If you are new, start with something small and learn >> from that. Don't do a controversial big patchset spanning multiple >> subsystems, that's the hard way to learn things. First submit one patch >> at a time to one subsystem and gain understanding of the process that >> way. > > I actually thought this would be such simple thing. If there are 22 patches and a dozen different subsystems it's far from simple, as you noticed from your replies :) > Do you know of any good thing where to start? I already looked into > drivers/staging/*/TODO and didn't found something for me personally. I work in wireless and one my annoyance is use of BUG_ON() in wireless drivers. There just isn't a good reason to crash the whole system when there's a bug in a wireless driver or firmware. You can get list like this: git grep BUG_ON drivers/net/wireless/ | grep -v BUILD_BUG_ON It might not be always trivial to fix BUG_ON() usage, so it would be a good challenge as well. See the wiki link below how to submit wireless patches. But just send a one patch first, don't work for several hours and then submit a big set of patches. We also might have a todo list somewhere in the wiki, but don't know how to up-to-date it is. > Should I drop this patchset and start with something different? Like Mauro suggested, splitting the patchset per subsystem is a very good idea. And first try out with one subsystem, and after seeing how it goes (if they are accepted or rejected), decide if you send more patches to other subsystems. > If yes, what would the proper way to drop it? Just announcing, that > this is going nowhere in a separate patch? Replying to Mauro's email and telling your intentions is a good way to inform everyone. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 271E9C433EF for ; Mon, 28 Mar 2022 12:32:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KRsX54mSyz3c4b for ; Mon, 28 Mar 2022 23:32:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=vR3sm0Sy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kvalo@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=vR3sm0Sy; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KRsWL4dbCz2xm1 for ; Mon, 28 Mar 2022 23:31:26 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19B6F60B87; Mon, 28 Mar 2022 12:31:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A869FC340EC; Mon, 28 Mar 2022 12:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648470682; bh=fLGdb7dSfAqcoc7SmA0DtwuG5S8J1UMKX6NM0JYvlbE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=vR3sm0Sym9PNeV1iKQGwMQbPO6yRDwohIBCSBdBAAXuDDO0SWpja6OgX6EnOvgTmq TjnzAmmgRqAI7VMMqH2O7CUJ6XEWGQoPVF1AN2lYHSalQOuTT+xH3TeXiapzkBoDDY tTzTYQ5GBWa2GALcTzd9hSykzmqjjHuEIfoQNXYeYukvQqZVWjJgo1IrRVnWgagObl g/dwjiafO/fytUgqLw8IWTrjQWjo/zqFAaNAJAQ8gjKtytzwyaZGjuidRKQhih/yde bDhRRLmxOXxLsSy40enpsfgnUm8nwGiwmrDs+aoLJB2mBmG7Pk8oHcDE3szRC3iHWp ESPsCuNOlpy8A== From: Kalle Valo To: Benjamin =?utf-8?Q?St=C3=BCrz?= Subject: Re: [PATCH 00/22] Replace comments with C99 initializers References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> Date: Mon, 28 Mar 2022 15:31:14 +0300 In-Reply-To: ("Benjamin \=\?utf-8\?Q\?St\=C3\=BCrz\=22's\?\= message of "Mon, 28 Mar 2022 13:51:42 +0200") Message-ID: <87bkxqz2b1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-media@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, wcn36xx@lists.infradead.org, linux-edac@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devel@acpica.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Benjamin St=C3=BCrz writes: > On 28.03.22 11:33, Kalle Valo wrote: >> Benjamin St=C3=BCrz writes: >>=20 >>> This patch series replaces comments with C99's designated initializers >>> in a few places. It also adds some enum initializers. This is my first >>> time contributing to the Linux kernel, therefore I'm probably doing a >>> lot of things the wrong way. I'm sorry for that. >>=20 >> Just a small tip: If you are new, start with something small and learn >> from that. Don't do a controversial big patchset spanning multiple >> subsystems, that's the hard way to learn things. First submit one patch >> at a time to one subsystem and gain understanding of the process that >> way. > > I actually thought this would be such simple thing. If there are 22 patches and a dozen different subsystems it's far from simple, as you noticed from your replies :) > Do you know of any good thing where to start? I already looked into > drivers/staging/*/TODO and didn't found something for me personally. I work in wireless and one my annoyance is use of BUG_ON() in wireless drivers. There just isn't a good reason to crash the whole system when there's a bug in a wireless driver or firmware. You can get list like this: git grep BUG_ON drivers/net/wireless/ | grep -v BUILD_BUG_ON It might not be always trivial to fix BUG_ON() usage, so it would be a good challenge as well. See the wiki link below how to submit wireless patches. But just send a one patch first, don't work for several hours and then submit a big set of patches. We also might have a todo list somewhere in the wiki, but don't know how to up-to-date it is. > Should I drop this patchset and start with something different?=20 Like Mauro suggested, splitting the patchset per subsystem is a very good idea. And first try out with one subsystem, and after seeing how it goes (if they are accepted or rejected), decide if you send more patches to other subsystems. > If yes, what would the proper way to drop it? Just announcing, that > this is going nowhere in a separate patch? Replying to Mauro's email and telling your intentions is a good way to inform everyone. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07753C433EF for ; Mon, 28 Mar 2022 12:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Kmv5ytDUN/du7NZod/r2TH2FC1PAJIDXDoM59T9rkE=; b=k3K6Ui4Ec2/itl j8ipnrbI+05Nl00Q0zcg4Df0EC45V19d/aCrHd4aQyibrctYW/6MQX00bi3KYHzNnAi1MRvpYJtjP aepZ8piZqz3bVHBQ12az+bRSC63Zw04MQCY1cKf5lDOSndXCkAp7OJ1H8kLg48JQsSiNHGKovwVe/ ATX71BQD7NUpvWC+tFas+e0/73UyX1+zCJzO9Ww8apeCOFoVGk+iYH19UvwPhop3uZEZs4pHwSAnZ 5xLowSlQgiLDvTg0lIm8VEQxWlaOv/p1IikNS2DnT0X3HddgGZ+pcEeUTJReVyjJw9/p1/5iMmUJB nbxV9VMUncWlIF6zCQ9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYoWs-008YTX-E2; Mon, 28 Mar 2022 12:31:26 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYoWp-008YSs-Jh; Mon, 28 Mar 2022 12:31:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19B6F60B87; Mon, 28 Mar 2022 12:31:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A869FC340EC; Mon, 28 Mar 2022 12:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648470682; bh=fLGdb7dSfAqcoc7SmA0DtwuG5S8J1UMKX6NM0JYvlbE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=vR3sm0Sym9PNeV1iKQGwMQbPO6yRDwohIBCSBdBAAXuDDO0SWpja6OgX6EnOvgTmq TjnzAmmgRqAI7VMMqH2O7CUJ6XEWGQoPVF1AN2lYHSalQOuTT+xH3TeXiapzkBoDDY tTzTYQ5GBWa2GALcTzd9hSykzmqjjHuEIfoQNXYeYukvQqZVWjJgo1IrRVnWgagObl g/dwjiafO/fytUgqLw8IWTrjQWjo/zqFAaNAJAQ8gjKtytzwyaZGjuidRKQhih/yde bDhRRLmxOXxLsSy40enpsfgnUm8nwGiwmrDs+aoLJB2mBmG7Pk8oHcDE3szRC3iHWp ESPsCuNOlpy8A== From: Kalle Valo To: Benjamin =?utf-8?Q?St=C3=BCrz?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 00/22] Replace comments with C99 initializers References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> Date: Mon, 28 Mar 2022 15:31:14 +0300 In-Reply-To: ("Benjamin \=\?utf-8\?Q\?St\=C3\=BCrz\=22's\?\= message of "Mon, 28 Mar 2022 13:51:42 +0200") Message-ID: <87bkxqz2b1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_053123_756509_2CCC22F5 X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QmVuamFtaW4gU3TDvHJ6IDxiZW5uaUBzdHVlcnoueHl6PiB3cml0ZXM6Cgo+IE9uIDI4LjAzLjIy IDExOjMzLCBLYWxsZSBWYWxvIHdyb3RlOgo+PiBCZW5qYW1pbiBTdMO8cnogPGJlbm5pQHN0dWVy ei54eXo+IHdyaXRlczoKPj4gCj4+PiBUaGlzIHBhdGNoIHNlcmllcyByZXBsYWNlcyBjb21tZW50 cyB3aXRoIEM5OSdzIGRlc2lnbmF0ZWQgaW5pdGlhbGl6ZXJzCj4+PiBpbiBhIGZldyBwbGFjZXMu IEl0IGFsc28gYWRkcyBzb21lIGVudW0gaW5pdGlhbGl6ZXJzLiBUaGlzIGlzIG15IGZpcnN0Cj4+ PiB0aW1lIGNvbnRyaWJ1dGluZyB0byB0aGUgTGludXgga2VybmVsLCB0aGVyZWZvcmUgSSdtIHBy b2JhYmx5IGRvaW5nIGEKPj4+IGxvdCBvZiB0aGluZ3MgdGhlIHdyb25nIHdheS4gSSdtIHNvcnJ5 IGZvciB0aGF0Lgo+PiAKPj4gSnVzdCBhIHNtYWxsIHRpcDogSWYgeW91IGFyZSBuZXcsIHN0YXJ0 IHdpdGggc29tZXRoaW5nIHNtYWxsIGFuZCBsZWFybgo+PiBmcm9tIHRoYXQuIERvbid0IGRvIGEg Y29udHJvdmVyc2lhbCBiaWcgcGF0Y2hzZXQgc3Bhbm5pbmcgbXVsdGlwbGUKPj4gc3Vic3lzdGVt cywgdGhhdCdzIHRoZSBoYXJkIHdheSB0byBsZWFybiB0aGluZ3MuIEZpcnN0IHN1Ym1pdCBvbmUg cGF0Y2gKPj4gYXQgYSB0aW1lIHRvIG9uZSBzdWJzeXN0ZW0gYW5kIGdhaW4gdW5kZXJzdGFuZGlu ZyBvZiB0aGUgcHJvY2VzcyB0aGF0Cj4+IHdheS4KPgo+IEkgYWN0dWFsbHkgdGhvdWdodCB0aGlz IHdvdWxkIGJlIHN1Y2ggc2ltcGxlIHRoaW5nLgoKSWYgdGhlcmUgYXJlIDIyIHBhdGNoZXMgYW5k IGEgZG96ZW4gZGlmZmVyZW50IHN1YnN5c3RlbXMgaXQncyBmYXIgZnJvbQpzaW1wbGUsIGFzIHlv dSBub3RpY2VkIGZyb20geW91ciByZXBsaWVzIDopCgo+IERvIHlvdSBrbm93IG9mIGFueSBnb29k IHRoaW5nIHdoZXJlIHRvIHN0YXJ0PyBJIGFscmVhZHkgbG9va2VkIGludG8KPiBkcml2ZXJzL3N0 YWdpbmcvKi9UT0RPIGFuZCBkaWRuJ3QgZm91bmQgc29tZXRoaW5nIGZvciBtZSBwZXJzb25hbGx5 LgoKSSB3b3JrIGluIHdpcmVsZXNzIGFuZCBvbmUgbXkgYW5ub3lhbmNlIGlzIHVzZSBvZiBCVUdf T04oKSBpbiB3aXJlbGVzcwpkcml2ZXJzLiBUaGVyZSBqdXN0IGlzbid0IGEgZ29vZCByZWFzb24g dG8gY3Jhc2ggdGhlIHdob2xlIHN5c3RlbSB3aGVuCnRoZXJlJ3MgYSBidWcgaW4gYSB3aXJlbGVz cyBkcml2ZXIgb3IgZmlybXdhcmUuIFlvdSBjYW4gZ2V0IGxpc3QgbGlrZQp0aGlzOgoKZ2l0IGdy ZXAgQlVHX09OIGRyaXZlcnMvbmV0L3dpcmVsZXNzLyB8IGdyZXAgLXYgQlVJTERfQlVHX09OCgpJ dCBtaWdodCBub3QgYmUgYWx3YXlzIHRyaXZpYWwgdG8gZml4IEJVR19PTigpIHVzYWdlLCBzbyBp dCB3b3VsZCBiZSBhCmdvb2QgY2hhbGxlbmdlIGFzIHdlbGwuIFNlZSB0aGUgd2lraSBsaW5rIGJl bG93IGhvdyB0byBzdWJtaXQgd2lyZWxlc3MKcGF0Y2hlcy4gQnV0IGp1c3Qgc2VuZCBhIG9uZSBw YXRjaCBmaXJzdCwgZG9uJ3Qgd29yayBmb3Igc2V2ZXJhbCBob3VycwphbmQgdGhlbiBzdWJtaXQg YSBiaWcgc2V0IG9mIHBhdGNoZXMuCgpXZSBhbHNvIG1pZ2h0IGhhdmUgYSB0b2RvIGxpc3Qgc29t ZXdoZXJlIGluIHRoZSB3aWtpLCBidXQgZG9uJ3Qga25vdyBob3cKdG8gdXAtdG8tZGF0ZSBpdCBp cy4KCj4gU2hvdWxkIEkgZHJvcCB0aGlzIHBhdGNoc2V0IGFuZCBzdGFydCB3aXRoIHNvbWV0aGlu ZyBkaWZmZXJlbnQ/IAoKTGlrZSBNYXVybyBzdWdnZXN0ZWQsIHNwbGl0dGluZyB0aGUgcGF0Y2hz ZXQgcGVyIHN1YnN5c3RlbSBpcyBhIHZlcnkKZ29vZCBpZGVhLiBBbmQgZmlyc3QgdHJ5IG91dCB3 aXRoIG9uZSBzdWJzeXN0ZW0sIGFuZCBhZnRlciBzZWVpbmcgaG93IGl0CmdvZXMgKGlmIHRoZXkg YXJlIGFjY2VwdGVkIG9yIHJlamVjdGVkKSwgZGVjaWRlIGlmIHlvdSBzZW5kIG1vcmUgcGF0Y2hl cwp0byBvdGhlciBzdWJzeXN0ZW1zLgoKPiBJZiB5ZXMsIHdoYXQgd291bGQgdGhlIHByb3BlciB3 YXkgdG8gZHJvcCBpdD8gSnVzdCBhbm5vdW5jaW5nLCB0aGF0Cj4gdGhpcyBpcyBnb2luZyBub3do ZXJlIGluIGEgc2VwYXJhdGUgcGF0Y2g/CgpSZXBseWluZyB0byBNYXVybydzIGVtYWlsIGFuZCB0 ZWxsaW5nIHlvdXIgaW50ZW50aW9ucyBpcyBhIGdvb2Qgd2F5IHRvCmluZm9ybSBldmVyeW9uZS4K Ci0tIApodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QvbGludXgtd2lyZWxlc3Mv bGlzdC8KCmh0dHBzOi8vd2lyZWxlc3Mud2lraS5rZXJuZWwub3JnL2VuL2RldmVsb3BlcnMvZG9j dW1lbnRhdGlvbi9zdWJtaXR0aW5ncGF0Y2hlcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=