From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EF64C433F5 for ; Wed, 16 Mar 2022 13:10:27 +0000 (UTC) Received: from localhost ([::1]:41860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUTQ2-0007GX-2n for qemu-devel@archiver.kernel.org; Wed, 16 Mar 2022 09:10:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUTGQ-0000qI-6H for qemu-devel@nongnu.org; Wed, 16 Mar 2022 09:00:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUTGO-0008BH-NN for qemu-devel@nongnu.org; Wed, 16 Mar 2022 09:00:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647435628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3fJ4mDFw3xzZsB1z1DLCj97gII0KwHS8bl4SjBAtNVk=; b=bYPwvxsa6ms1NXojV7URmTEmNGAUKmUrI78XTCr6Xv0xvUurLqSTSslAexVqZBNM6LyABy cI5WWmRvCvu1afOvSSPcpdp3C25FdB+ko9QSgiaBwG8/5cRQCUn/e1hntz8ULmp9BPf9uS gH26CGGhiZ7V66nWobAho3IyKg2rnrk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-274-lHQ6hXP6MhmzRh-nf4kc5w-1; Wed, 16 Mar 2022 09:00:26 -0400 X-MC-Unique: lHQ6hXP6MhmzRh-nf4kc5w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90033811E84 for ; Wed, 16 Mar 2022 13:00:26 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5ECA4401E39; Wed, 16 Mar 2022 13:00:26 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F0CC921E6821; Wed, 16 Mar 2022 14:00:24 +0100 (CET) From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH 26/27] tests: replace free_all() usage with g_auto References: <20220316095459.2613885-1-marcandre.lureau@redhat.com> <877d8u5b7o.fsf@pond.sub.org> Date: Wed, 16 Mar 2022 14:00:24 +0100 In-Reply-To: (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Wed, 16 Mar 2022 16:53:05 +0400") Message-ID: <87bky6xdav.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Marc-Andr=C3=A9 Lureau writes: > Hi > > On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster wro= te: >> >> marcandre.lureau@redhat.com writes: >> >> > From: Marc-Andr=C3=A9 Lureau >> > >> > Use more idiomatic glib/auto-style code. >> > >> > Signed-off-by: Marc-Andr=C3=A9 Lureau >> >> This is a bit of an improvement, but by its own, it's a rather weak >> justification for the previous patch. Do you have more uses of >> g_autoptr in the pipe? > > > There are a lot of similar g_auto cleanups to be done in qemu code > base for QObject types. But I started with those tests, because they > use a pretty unorthodox free_all pattern and that shouldn't be > repeated. Would it make sense to add this the list of bite-sized tasks?