All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org, petri.latvala@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/2] test/perf_pmu: Change module unload assertion
Date: Mon, 21 Feb 2022 12:29:33 -0800	[thread overview]
Message-ID: <87bkz06k0i.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220221102423.8089-3-anshuman.gupta@intel.com>

On Mon, 21 Feb 2022 02:24:23 -0800, Anshuman Gupta wrote:
>
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 4f3cb6145..a7f26c80f 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -2101,7 +2101,7 @@ static void test_unload(unsigned int num_engines)
>
>		igt_debug("Read %d events from perf and trial unload\n", count);
>		pmu_read_multi(fd[0], count, buf);
> -		igt_assert_eq(__igt_i915_driver_unload(NULL), IGT_EXIT_SKIP);
> +		igt_assert_neq(__igt_i915_driver_unload(NULL), 0);

To be completely equivalent to IGT_EXIT_SKIP (before we broke it), I think
let us pass in a 'who' and make the condition: "ret != 0 && 'who' indicates
it is i915 which failed to unload".

  reply	other threads:[~2022-02-21 20:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 10:24 [igt-dev] [PATCH i-g-t v2 0/2] Avoid process exit return values in igt_kmod Anshuman Gupta
2022-02-21 10:24 ` [igt-dev] [PATCH i-g-t v2 1/2] lib/igt_kmod: Don't use process exit return value Anshuman Gupta
2022-02-21 20:28   ` Dixit, Ashutosh
2022-02-21 10:24 ` [igt-dev] [PATCH i-g-t v2 2/2] test/perf_pmu: Change module unload assertion Anshuman Gupta
2022-02-21 20:29   ` Dixit, Ashutosh [this message]
2022-02-21 14:19 ` [igt-dev] ✗ Fi.CI.BAT: failure for Avoid process exit return values in igt_kmod (rev2) Patchwork
2022-02-21 17:24   ` Anshuman Gupta
2022-02-22  3:45 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-02-22  5:13 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkz06k0i.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.