From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
lorenzo.bianconi@redhat.com, davem@davemloft.net,
kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
dsahern@kernel.org, komachi.yoshiki@gmail.com, brouer@redhat.com,
memxor@gmail.com, andrii.nakryiko@gmail.com
Subject: Re: [RFC bpf-next 1/2] net: bridge: add unstable br_fdb_find_port_from_ifindex helper
Date: Wed, 26 Jan 2022 13:03:56 +0100 [thread overview]
Message-ID: <87bkzy3dqr.fsf@toke.dk> (raw)
In-Reply-To: <YfEzl0wL+51wa6z7@lore-desk>
Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> > + rcu_read_lock();
>>
>> This is not needed when the function is only being called from XDP...
>
> don't we need it since we do not hold the rtnl here?
No. XDP programs always run under local_bh_disable() which "counts" as
an rcu_read_lock(); I did some cleanup around this a while ago, see this
commit for a longer explanation:
782347b6bcad ("xdp: Add proper __rcu annotations to redirect map entries")
-Toke
next prev parent reply other threads:[~2022-01-26 12:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:20 [RFC bpf-next 0/2] introduce bpf fdb lookup helper for xdp Lorenzo Bianconi
2022-01-24 17:20 ` [RFC bpf-next 1/2] net: bridge: add unstable br_fdb_find_port_from_ifindex helper Lorenzo Bianconi
2022-01-24 17:50 ` Toke Høiland-Jørgensen
2022-01-26 11:42 ` Lorenzo Bianconi
2022-01-26 12:03 ` Kumar Kartikeya Dwivedi
2022-01-26 20:11 ` Andrii Nakryiko
2022-01-26 12:03 ` Toke Høiland-Jørgensen [this message]
2022-01-26 14:04 ` Lorenzo Bianconi
2022-01-24 18:32 ` Nikolay Aleksandrov
2022-01-24 18:32 ` [Bridge] " Nikolay Aleksandrov
2022-01-25 5:09 ` Alexei Starovoitov
2022-01-25 5:09 ` [Bridge] " Alexei Starovoitov
2022-01-26 11:09 ` Lorenzo Bianconi
2022-01-26 11:09 ` [Bridge] " Lorenzo Bianconi
2022-01-26 12:02 ` Toke Høiland-Jørgensen
2022-01-26 12:02 ` [Bridge] " Toke Høiland-Jørgensen
2022-01-26 11:27 ` Lorenzo Bianconi
2022-01-26 11:27 ` [Bridge] " Lorenzo Bianconi
2022-01-26 12:08 ` Kumar Kartikeya Dwivedi
2022-01-26 12:08 ` [Bridge] " Kumar Kartikeya Dwivedi
2022-01-26 12:39 ` Nikolay Aleksandrov
2022-01-26 12:39 ` [Bridge] " Nikolay Aleksandrov
2022-01-26 12:50 ` Toke Høiland-Jørgensen
2022-01-26 12:50 ` [Bridge] " Toke Høiland-Jørgensen
2022-01-26 12:57 ` Nikolay Aleksandrov
2022-01-26 12:57 ` [Bridge] " Nikolay Aleksandrov
2022-01-26 15:00 ` Lorenzo Bianconi
2022-01-26 15:00 ` [Bridge] " Lorenzo Bianconi
2022-01-24 17:20 ` [RFC bpf-next 2/2] samples: bpf: add xdp fdb lookup program Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkzy3dqr.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=komachi.yoshiki@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.