From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35AA4C433F5 for ; Thu, 20 Jan 2022 11:01:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 868F210E269; Thu, 20 Jan 2022 11:01:56 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A63F910E1F9 for ; Thu, 20 Jan 2022 11:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642676514; x=1674212514; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=U8MzxhseFdbfDm8GwZVwPEamsNRt7437AM0rkm6e/7E=; b=lsOYOz0xnPYRTaEUymMl7DlKpkNI6YMu8kvPPWfiw1u3LBcs6isBRoQs fZ3980hr0gc53TbbdlBO3nbAcS5EhaSr0UgBDRyzggLVkcXZT5tuPJtqG DbCs/3u8DhQgAPFYCr123aybQBRgRAGa/KYC8Y22ujIGIToiih1lzmFZk 7azl0WA1TC54BPpSt5Z4Agw0IPa63/JZnd7UGAnrZR+TwU3qLvvr3lMjT yaXt/Gm3LFbPWvDDhsbbEOr0MaehDcJ16YHLOCAzqvF+CTy2DtKGrK/CO FcdDKlrIbb3k3q0Nr04bVszuDQbt8VJwxumc0pMdwxP7PLViHvlaNK0Li A==; X-IronPort-AV: E=McAfee;i="6200,9189,10232"; a="226001062" X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="226001062" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 03:01:53 -0800 X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="518572224" Received: from davidfsc-mobl3.ger.corp.intel.com (HELO localhost) ([10.252.52.140]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 03:01:50 -0800 From: Jani Nikula To: "Shankar, Uma" , "intel-gfx@lists.freedesktop.org" In-Reply-To: <2e0b588d721e46a4ad9e94604421135f@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220112110319.1172110-1-jani.nikula@intel.com> <20220112110319.1172110-7-jani.nikula@intel.com> <2e0b588d721e46a4ad9e94604421135f@intel.com> Date: Thu, 20 Jan 2022 13:01:45 +0200 Message-ID: <87bl06acx2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we actually handled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 20 Jan 2022, "Shankar, Uma" wrote: >> -----Original Message----- >> From: Intel-gfx On Behalf Of Jani Nikula >> Sent: Wednesday, January 12, 2022 4:33 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani >> Subject: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we actually >> handled >> >> Seems odd that we clear all event status indicators if we've only handled some. Only >> clear the ones we've handled. > > Looks Good to me. > Reviewed-by: Uma Shankar Thanks, please also see v2 of this patch I accidentally posted to the old thread first. I guess you were replying to two threads too. :) BR, Jani > >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++++-------- >> 1 file changed, 12 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c >> b/drivers/gpu/drm/i915/display/intel_dp.c >> index 95e9f7220ab8..548419a4ead8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >> @@ -3625,13 +3625,17 @@ static void intel_dp_handle_test_request(struct >> intel_dp *intel_dp) } >> >> static void >> -intel_dp_mst_hpd_irq(struct intel_dp *intel_dp, u8 *esi, bool *handled) >> +intel_dp_mst_hpd_irq(struct intel_dp *intel_dp, u8 *esi, u8 *ack) >> { >> - drm_dp_mst_hpd_irq(&intel_dp->mst_mgr, esi, handled); >> + bool handled = false; >> + >> + drm_dp_mst_hpd_irq(&intel_dp->mst_mgr, esi, &handled); >> + if (handled) >> + ack[1] |= DP_DOWN_REP_MSG_RDY | DP_UP_REQ_MSG_RDY; >> >> if (esi[1] & DP_CP_IRQ) { >> intel_hdcp_handle_cp_irq(intel_dp->attached_connector); >> - *handled = true; >> + ack[1] |= DP_CP_IRQ; >> } >> } >> >> @@ -3683,7 +3687,7 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp) >> >> for (;;) { >> u8 esi[4] = {}; >> - bool handled; >> + u8 ack[4] = {}; >> >> if (!intel_dp_get_sink_irq_esi(intel_dp, esi)) { >> drm_dbg_kms(&i915->drm, >> @@ -3699,15 +3703,15 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp) >> esi[3] & LINK_STATUS_CHANGED) { >> if (!intel_dp_mst_link_status(intel_dp)) >> link_ok = false; >> - handled = true; >> + ack[3] |= LINK_STATUS_CHANGED; >> } >> >> - intel_dp_mst_hpd_irq(intel_dp, esi, &handled); >> + intel_dp_mst_hpd_irq(intel_dp, esi, ack); >> >> - if (!handled) >> + if (!memchr_inv(ack, 0, sizeof(ack))) >> break; >> >> - if (!intel_dp_ack_sink_irq_esi(intel_dp, esi)) >> + if (!intel_dp_ack_sink_irq_esi(intel_dp, ack)) >> drm_dbg_kms(&i915->drm, "Failed to ack ESI\n"); >> } >> >> -- >> 2.30.2 > -- Jani Nikula, Intel Open Source Graphics Center