From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Jonas Jelonek <jelonek.jonas@gmail.com>, linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org, nbd@nbd.name,
Jonas Jelonek <jelonek.jonas@gmail.com>,
Thomas Huehn <thomas.huehn@hs-nordhausen.de>
Subject: Re: [PATCH v2] ath9k: switch to rate table based lookup
Date: Mon, 29 Nov 2021 12:46:53 +0100 [thread overview]
Message-ID: <87bl239ob6.fsf@toke.dk> (raw)
In-Reply-To: <20211128090753.958-1-jelonek.jonas@gmail.com>
Jonas Jelonek <jelonek.jonas@gmail.com> writes:
> This patch changes mac80211 rate control for the ath9k driver.
> The rate lookup per packet is changed from legacy usage of
> ieee80211_get_tx_rates() to the new rate table based lookup in struct
> ieee80211_sta->rates.
>
> The most recent rate control API (introduced with
> 0d528d85c519b755b6f4e1bafa3a39984370e1c1) allows drivers to directly get
> rates from ieee80211_sta->rates. This is not used by every driver yet,
> the translation/merge is currently performed in ieee80211_get_tx_rates.
> This patch changes the behaviour and avoids the call to
> ieee80211_get_tx_rates and subsequent calls. ath9k now directly reads
> rates from sta->rates into its rate table. Cause ath9k does not
> expect rate selection in SKB->CB, the table merge does not consider rate
> array in SKB->CB except for the first entry (used for probing).
>
> Tested with a 8devices Rambutan with QCA9558 SoC by performing two
> runs, one without the patch and one with. Generated traffic between
> AP and multiple STAs in each run, measured throughput and captured rc_stats.
> Comparison of both runs resulted in same rate selection and no
> performance loss or other negative effects.
>
> Co-developed-by: Thomas Huehn <thomas.huehn@hs-nordhausen.de>
> Signed-off-by: Thomas Huehn <thomas.huehn@hs-nordhausen.de>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Better, thanks!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2021-11-29 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 9:07 [PATCH v2] ath9k: switch to rate table based lookup Jonas Jelonek
2021-11-29 11:46 ` Toke Høiland-Jørgensen [this message]
2021-12-07 15:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl239ob6.fsf@toke.dk \
--to=toke@redhat.com \
--cc=jelonek.jonas@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=thomas.huehn@hs-nordhausen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.