From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317C8C433EF for ; Sun, 24 Oct 2021 15:50:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19BFA60FD7 for ; Sun, 24 Oct 2021 15:50:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhJXPxE (ORCPT ); Sun, 24 Oct 2021 11:53:04 -0400 Received: from foss.arm.com ([217.140.110.172]:38342 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbhJXPxE (ORCPT ); Sun, 24 Oct 2021 11:53:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C753D6E; Sun, 24 Oct 2021 08:50:42 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34C5B3F5A1; Sun, 24 Oct 2021 08:50:41 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Thomas Gleixner , Sebastian Andrzej Siewior , Ard Biesheuvel Subject: Re: [PATCH 1/3] irqchip/gic-v3-its: Give the percpu rdist struct its own flags field In-Reply-To: <87r1cct8cw.wl-maz@kernel.org> References: <20211022103307.1711619-1-valentin.schneider@arm.com> <20211022103307.1711619-2-valentin.schneider@arm.com> <87r1cct8cw.wl-maz@kernel.org> Date: Sun, 24 Oct 2021 16:50:34 +0100 Message-ID: <87bl3ejub9.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On 23/10/21 10:10, Marc Zyngier wrote: > On Fri, 22 Oct 2021 11:33:05 +0100, > Valentin Schneider wrote: >> -#define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) >> -#define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) >> +#define RDISTS_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) >> +#define RDISTS_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) >> + >> +#define RDIST_FLAGS_LPI_ENABLED BIT(0) > > Just to reduce the churn and for me not to misread things (because > RDIST/RDISTS is pretty confusing), how about leaving the original > flags as is, and name the per-RD ones like: > > #define RD_LOCAL_LPI_ENABLED BIT(0) > > ? > > Or something else that'd be adequately different from the original > flags? > Aye, sounds like the right thing to do! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75720C433EF for ; Sun, 24 Oct 2021 15:52:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38B656052B for ; Sun, 24 Oct 2021 15:52:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 38B656052B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SwBpEDsMRWbxJbS8g7CBUms1HG5AAg6nNsFcw+6153g=; b=I6SPP8pED6NA9L SFz/PAqChChBp4EnqbwUeX8zPdOtIZWwXWyf5KPq9IpiYk2jedtUmVOCyKIFS8sbzOuAmgdJx/9iv XqQp7dz0rNc1Nm8HZ6tkkeKUUKis35gYGg9FnQqu0EQnWTTJifsQC5Ris9YopSosKcAWJom/7Xtns KliNfHSJy4TUubWnKY+s+Uc8yWVbffWwQq1OpZ2mLfWN6fjuYm6HWiB2EeCvOz0YJx0IYUNxSSOrN PQDdeGBAC/fbXHSsAB229vQ46PnZkSnXDZhpBXkEg8LPZKtNxTfBzbeolANLuWs7wT+II2mT6Nm9U 8jsMLohOX0Jx2DoHXhVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1meflr-00EGho-DT; Sun, 24 Oct 2021 15:50:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mefll-00EGff-8a for linux-arm-kernel@lists.infradead.org; Sun, 24 Oct 2021 15:50:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C753D6E; Sun, 24 Oct 2021 08:50:42 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34C5B3F5A1; Sun, 24 Oct 2021 08:50:41 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Thomas Gleixner , Sebastian Andrzej Siewior , Ard Biesheuvel Subject: Re: [PATCH 1/3] irqchip/gic-v3-its: Give the percpu rdist struct its own flags field In-Reply-To: <87r1cct8cw.wl-maz@kernel.org> References: <20211022103307.1711619-1-valentin.schneider@arm.com> <20211022103307.1711619-2-valentin.schneider@arm.com> <87r1cct8cw.wl-maz@kernel.org> Date: Sun, 24 Oct 2021 16:50:34 +0100 Message-ID: <87bl3ejub9.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211024_085045_397960_E31F22E9 X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/10/21 10:10, Marc Zyngier wrote: > On Fri, 22 Oct 2021 11:33:05 +0100, > Valentin Schneider wrote: >> -#define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) >> -#define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) >> +#define RDISTS_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) >> +#define RDISTS_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) >> + >> +#define RDIST_FLAGS_LPI_ENABLED BIT(0) > > Just to reduce the churn and for me not to misread things (because > RDIST/RDISTS is pretty confusing), how about leaving the original > flags as is, and name the per-RD ones like: > > #define RD_LOCAL_LPI_ENABLED BIT(0) > > ? > > Or something else that'd be adequately different from the original > flags? > Aye, sounds like the right thing to do! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel