All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Zhen Lei <thunder.leizhen@huawei.com>,
	Joe Perches <joe@perches.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	Jason Baron <jbaron@akamai.com>,
	Stefani Seibold <stefani@seibold.net>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Thomas Graf <tgraf@suug.ch>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Jens Axboe <axboe@kernel.dk>, Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH v2 1/3] scripts: add spelling_sanitizer.sh script
Date: Wed, 16 Jun 2021 08:53:51 -0600	[thread overview]
Message-ID: <87bl85yi68.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210616122507.896-2-thunder.leizhen@huawei.com>

Zhen Lei <thunder.leizhen@huawei.com> writes:

> The file scripts/spelling.txt recorded a large number of spelling
> "mistake||correction" pairs. These entries are currently maintained in
> order, but the results are not strict. In addition, when someone wants to
> add some new pairs, he either sort them manually or write a script, which
> is clearly a waste of labor. So add this script. For all spelling
> "mistake||correction" pairs, sort based on "correction", then on "mistake",
> and remove duplicates. Sorting based on "mistake" first is not chosen
> because it is uncontrollable.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  scripts/spelling_sanitizer.sh | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100755 scripts/spelling_sanitizer.sh
>
> diff --git a/scripts/spelling_sanitizer.sh b/scripts/spelling_sanitizer.sh
> new file mode 100755
> index 000000000000..603bb7e0e66b
> --- /dev/null
> +++ b/scripts/spelling_sanitizer.sh
> @@ -0,0 +1,27 @@
> +#!/bin/sh -efu
> +# SPDX-License-Identifier: GPL-2.0
> +
> +# To get the traditional sort order that uses native byte values

So I am of the naive opinion that everything we drop into scripts/
should start with a comment saying why it exists and how to use it.
Otherwise how are people going to benefit from it?

Thanks,

jon

  reply	other threads:[~2021-06-16 14:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 12:25 [PATCH v2 0/3] scripts/spelling.txt: add some spelling pairs and reorder Zhen Lei
2021-06-16 12:25 ` [PATCH v2 1/3] scripts: add spelling_sanitizer.sh script Zhen Lei
2021-06-16 14:53   ` Jonathan Corbet [this message]
2021-06-17  1:11     ` Leizhen (ThunderTown)
2021-06-17  7:32       ` Petr Mladek
2021-06-18  2:51         ` Leizhen (ThunderTown)
2021-06-16 12:25 ` [PATCH v2 2/3] scripts/spelling.txt: sort and remove duplicates Zhen Lei
2021-06-16 12:25 ` [PATCH v2 3/3] scripts/spelling.txt: add some spelling "mistake||correction" pairs Zhen Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl85yi68.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=herbert@gondor.apana.org.au \
    --cc=jacob.e.keller@intel.com \
    --cc=jbaron@akamai.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pmladek@suse.com \
    --cc=senozhatsky@chromium.org \
    --cc=stefani@seibold.net \
    --cc=tgraf@suug.ch \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.