From: Michael Ellerman <mpe@ellerman.id.au>
To: Leonardo Bras <leobras.c@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
brking@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR
Date: Thu, 08 Apr 2021 19:08:22 +1000 [thread overview]
Message-ID: <87blapdtyx.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <eed000bfa26686f616b91a7ac5a54ff8e3f2cbd0.camel@gmail.com>
Leonardo Bras <leobras.c@gmail.com> writes:
> On Thu, 2021-04-08 at 03:20 -0300, Leonardo Bras wrote:
>> > > +#define QUERY_DDW_PGSIZE_4K 0x01
>> > > +#define QUERY_DDW_PGSIZE_64K 0x02
>> > > +#define QUERY_DDW_PGSIZE_16M 0x04
>> > > +#define QUERY_DDW_PGSIZE_32M 0x08
>> > > +#define QUERY_DDW_PGSIZE_64M 0x10
>> > > +#define QUERY_DDW_PGSIZE_128M 0x20
>> > > +#define QUERY_DDW_PGSIZE_256M 0x40
>> > > +#define QUERY_DDW_PGSIZE_16G 0x80
>> >
>> > I'm not sure the #defines really gain us much vs just putting the
>> > literal values in the array below?
>>
>> My v1 did not use the define approach, what do you think of that?
>> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210322190943.715368-1-leobras.c@gmail.com/
>>
>>
> (of course, it would be that without the pageshift defines also, using
> the __builtin_ctz() approach suggested by Alexey.)
Yeah I think I like that better.
cheers
next prev parent reply other threads:[~2021-04-08 9:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 19:56 [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR Leonardo Bras
2021-04-08 0:22 ` kernel test robot
2021-04-08 0:22 ` kernel test robot
2021-04-08 0:22 ` kernel test robot
2021-04-08 5:37 ` Michael Ellerman
2021-04-08 6:20 ` Leonardo Bras
2021-04-08 6:35 ` Leonardo Bras
2021-04-08 9:08 ` Michael Ellerman [this message]
2021-04-08 7:13 ` Alexey Kardashevskiy
2021-04-08 9:04 ` Michael Ellerman
2021-04-09 4:36 ` Alexey Kardashevskiy
2021-04-09 4:44 ` Leonardo Bras
2021-04-12 22:21 ` Segher Boessenkool
2021-04-12 22:21 ` Segher Boessenkool
2021-04-14 4:02 ` Leonardo Bras
2021-04-14 4:02 ` Leonardo Bras
2021-04-08 7:48 ` kernel test robot
2021-04-08 7:48 ` kernel test robot
2021-04-08 7:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blapdtyx.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=brking@linux.vnet.ibm.com \
--cc=leobras.c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.