From: Tobias Waldekranz <tobias@waldekranz.com>
To: Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
George McCollister <george.mccollister@gmail.com>,
DENG Qingfang <dqfext@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hauke Mehrtens <hauke@hauke-m.de>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH net-next 2/4] net: dsa: reject switchdev objects centrally from dsa_slave_port_obj_{add,del}
Date: Thu, 25 Feb 2021 20:24:06 +0100 [thread overview]
Message-ID: <87blc8rlwp.fsf@waldekranz.com> (raw)
In-Reply-To: <20210214155326.1783266-3-olteanv@gmail.com>
On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean <olteanv@gmail.com> wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> The dsa_port_offloads_netdev check is inside dsa_slave_vlan_{add,del},
> but outside dsa_port_mdb_{add,del}. We can reduce the number of
> occurrences of dsa_port_offloads_netdev by checking only once, at the
> beginning of dsa_slave_port_obj_add and dsa_slave_port_obj_del.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
Reviewed-by: Tobias Waldekranz <tobias@waldekranz.com>
next prev parent reply other threads:[~2021-02-25 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 15:53 [PATCH net-next 0/4] Software fallback for bridging in DSA Vladimir Oltean
2021-02-14 15:53 ` [PATCH net-next 1/4] net: dsa: don't offload switchdev objects on ports that don't offload the bridge Vladimir Oltean
2021-02-25 19:23 ` Tobias Waldekranz
2021-02-14 15:53 ` [PATCH net-next 2/4] net: dsa: reject switchdev objects centrally from dsa_slave_port_obj_{add,del} Vladimir Oltean
2021-02-25 19:24 ` Tobias Waldekranz [this message]
2021-02-14 15:53 ` [PATCH net-next 3/4] net: dsa: return -EOPNOTSUPP if .port_lag_join is not implemented Vladimir Oltean
2021-02-25 19:24 ` Tobias Waldekranz
2021-02-14 15:53 ` [PATCH net-next 4/4] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge Vladimir Oltean
2021-02-15 15:48 ` George McCollister
2021-02-15 17:19 ` Vladimir Oltean
2021-02-25 19:25 ` Tobias Waldekranz
2021-02-26 18:14 ` Vladimir Oltean
2021-02-14 16:28 ` [PATCH net-next 0/4] Software fallback for bridging in DSA Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blc8rlwp.fsf@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux@rempel-privat.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.